Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/dart2js.dart

Issue 18125004: Don't request bug reports when aborting due to --throw-on-error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/dart2js.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/dart2js.dart b/dart/sdk/lib/_internal/compiler/implementation/dart2js.dart
index 635f8f0a45cb732ece397b03a4a12e47ce052899..a36c516012f24ba1647c1345a42068b9796ea1a1 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/dart2js.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/dart2js.dart
@@ -223,8 +223,7 @@ void compile(List<String> argv) {
List<String> arguments = <String>[];
List<OptionHandler> handlers = <OptionHandler>[
new OptionHandler('-[chv?]+', handleShortOptions),
- new OptionHandler('--throw-on-error',
- (_) => diagnosticHandler.throwOnError = true),
+ new OptionHandler('--throw-on-error', passThrough),
new OptionHandler('--suppress-warnings',
(_) => diagnosticHandler.showWarnings = false),
new OptionHandler('--suppress-hints',
@@ -390,12 +389,6 @@ class CountingSink implements EventSink<String> {
void close() { sink.close(); }
}
-class AbortLeg {
- final message;
- AbortLeg(this.message);
- toString() => 'Aborted due to --throw-on-error: $message';
-}
-
void writeString(Uri uri, String text) {
if (uri.scheme != 'file') {
fail('Error: Unhandled scheme ${uri.scheme}.');

Powered by Google App Engine
This is Rietveld 408576698