Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1811953003: Revert of ensure_goma for goma canary (Closed)

Created:
4 years, 9 months ago by scottmg
Modified:
4 years, 9 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, shinyak, Yoshisato Yanagisawa
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of ensure_goma for goma canary (patchset #1 id:1 of https://codereview.chromium.org/1814713002/ ) Reason for revert: Seems to have broken most bots, e.g. https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/108797/steps/ensure_goma/logs/stdio with Traceback (most recent call last): File "/b/build/scripts/slave/recipe_modules/goma/resources/ensure_goma.py", line 70, in <module> sys.exit(main(sys.argv[1:])) File "/b/build/scripts/slave/recipe_modules/goma/resources/ensure_goma.py", line 51, in main if arg.canary: NameError: global name 'arg' is not defined Original issue's description: > ensure_goma for goma canary > > for bot configured as goma_canary, it will use head of goma repo, > instead of pinned revision configured in ensure_goma.py > > BUG=595234 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299374 TBR=phajdan.jr@chromium.org,iannucci@chromium.org,ukai@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595234 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299375

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
scottmg
Created Revert of ensure_goma for goma canary
4 years, 9 months ago (2016-03-18 01:14:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811953003/1
4 years, 9 months ago (2016-03-18 01:15:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299375
4 years, 9 months ago (2016-03-18 01:15:18 UTC) #4
Dirk Pranke
4 years, 9 months ago (2016-03-18 01:15:34 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698