scripts/slave/recipe_modules/chromium/api.py - Issue 1811953003: Revert of ensure_goma for goma canary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 1811953003: Revert of ensure_goma for goma canary (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium/api.py

diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py

index e689796158d875b63ebfeecfd8a5777f96517e46..a08d87f0de7ec467382ed55ba9e3f675de1394de 100644

--- a/scripts/slave/recipe_modules/chromium/api.py

+++ b/scripts/slave/recipe_modules/chromium/api.py

@@ -474,7 +474,7 @@

self.c.gyp_env.GYP_DEFINES['gomadir'] = goma_dir

self.c.compile_py.goma_dir = goma_dir

- self.m.goma.ensure_goma(goma_dir, canary=self.c.compile_py.goma_canary)

+ self.m.goma.ensure_goma(goma_dir)

def runhooks(self, **kwargs):

"""Run the build-configuration hooks for chromium."""

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/config.py » ('j') | no next file with comments »