Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: scripts/slave/recipe_modules/goma/api.py

Issue 1811953003: Revert of ensure_goma for goma canary (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/goma/api.py
diff --git a/scripts/slave/recipe_modules/goma/api.py b/scripts/slave/recipe_modules/goma/api.py
index 2ee16f19272458b4291896bfe05a07774d9f71a9..16347eac088ef36cbd59eeb8b9bde6c31b643cbe 100644
--- a/scripts/slave/recipe_modules/goma/api.py
+++ b/scripts/slave/recipe_modules/goma/api.py
@@ -9,7 +9,6 @@
def update_goma_canary(self):
"""Returns a step for updating goma canary."""
- # deprecated? switch to use ensure_goma with canary=True.
# for git checkout, should use @refs/heads/master to use head.
head = 'refs/heads/master'
# TODO(phajdan.jr): Remove path['build'] usage, http://crbug.com/437264 .
@@ -18,17 +17,14 @@
'--revision', 'build/goma@%s' % head],
cwd=self.m.path['build'])
- def ensure_goma(self, goma_dir, canary=False):
+ def ensure_goma(self, goma_dir):
# TODO(iannucci): switch to CIPD (https://goto.google.com/toxxq).
- args=[
+ self.m.python(
+ name='ensure_goma',
+ script=self.resource('ensure_goma.py'),
+ args=[
'--target-dir', goma_dir,
'--download-from-google-storage-path',
self.m.depot_tools.download_from_google_storage_path
- ]
- if canary:
- args += ['--canary']
- self.m.python(
- name='ensure_goma',
- script=self.resource('ensure_goma.py'),
- args=args,
+ ],
infra_step=True)
« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/api.py ('k') | scripts/slave/recipe_modules/goma/resources/ensure_goma.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698