scripts/slave/recipe_modules/chromium/config.py - Issue 1811953003: Revert of ensure_goma for goma canary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 1811953003: Revert of ensure_goma for goma canary (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium/config.py

diff --git a/scripts/slave/recipe_modules/chromium/config.py b/scripts/slave/recipe_modules/chromium/config.py

index 84b30c35ddefc047e750115827f24a27cb76a8ef..635ba64706e9bc207d5a8480df4cc88490395c9a 100644

--- a/scripts/slave/recipe_modules/chromium/config.py

+++ b/scripts/slave/recipe_modules/chromium/config.py

@@ -40,7 +40,6 @@

compiler = Single(basestring, required=False),

mode = Single(basestring, required=False),

goma_dir = Single(Path, required=False),

- goma_canary = Single(bool, empty_val=False, required=False),

goma_hermetic = Single(basestring, required=False),

goma_enable_remote_link = Single(bool, empty_val=False, required=False),

goma_store_local_run_output = Single(bool, empty_val=False, required=False),

@@ -252,7 +251,6 @@

@config_ctx()

def goma_canary(c):

- c.compile_py.goma_canary = True

c.compile_py.goma_hermetic = 'error'

c.compile_py.goma_enable_compiler_info_cache = True