Enhance chrome.app.window API with better shelf integration

Enhance chrome.app.window API with better shelf integration

Enhance chrome.app.window API with the possibility of creating a window that
will show up separately in the shelf, tied to its own icon.

Added a new property, showInShelf, to CreateWindowOptions. Default value for
the property is false.

BUG=
TEST=interactive_ui_tests
Implement a simple extension that creates windows with the property set
to true. Observe that the newly created windows are added as separate icons in
the shelf.

[paul.sapunaru, 2016-03-16 14:47:02]

paul.sapunaru@intel.com changed reviewers:
+ robert.bradford@intel.com

[paul.sapunaru, 2016-03-17 15:38:53]

paul.sapunaru@intel.com changed reviewers:
+ stevenjb@chromium.org

[paul.sapunaru, 2016-03-17 15:38:54]

stevenjb@chromium.org: PTAL

[stevenjb, 2016-03-17 23:36:16]

We should also add a ShelfAppBrowserTest
(chrome_launcher_controller_browsertest.cc) that tests the following
combinations:

* An app with one show_in_shelf window
* An app with an initial window show_in_shelf=false and a second window with
show_in_shelf=true
* The inverse of the above (to define expected behavior; I would expect any
show_in_shelf window to not be grouped, i.e. 2 icons).
* An app with two windows with show_in_shelf=false and two with
show_in_shelf=true

https://codereview.chromium.org/1811523002/diff/20001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/app_window_launcher_controller.cc (right):

https://codereview.chromium.org/1811523002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/app_window_launcher_controller.cc:173: if
(shelf_id == 0 || app_window->show_in_shelf()) {
I think this logic would be more clear in the if statement on line 171 (also
less work).

https://codereview.chromium.org/1811523002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/app_window_launcher_controller.cc:185: //
showInShelf parameter is false.
Is this true? What if the first window created for the app has show_in_shelf set
to true?