Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: extensions/browser/app_window/app_window_interactive_uitest.cc

Issue 1811523002: Enhance chrome.app.window API with better shelf integration Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [WIP] Rebase + browser tests. Added a new map that holds all the showInShelf windows. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/app_window/app_window.cc ('k') | extensions/common/api/app_window.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/app_window_interactive_uitest.cc
diff --git a/extensions/browser/app_window/app_window_interactive_uitest.cc b/extensions/browser/app_window/app_window_interactive_uitest.cc
index cdf5c4c3296b24288441efc1cdb447d6f40af30a..8a56ef382cc52d7eba23a14ff3a05430554733a4 100644
--- a/extensions/browser/app_window/app_window_interactive_uitest.cc
+++ b/extensions/browser/app_window/app_window_interactive_uitest.cc
@@ -186,4 +186,16 @@ IN_PROC_BROWSER_TEST_F(AppWindowTest, MAYBE_DisableAlwaysOnTopInFullscreen) {
CloseAppWindow(window);
}
+// Tests a window created with showInShelf property enabled is indeed marked
+// as shown in shelf in AppWindow.
+IN_PROC_BROWSER_TEST_F(AppWindowTest, InitShowInShelf) {
+ AppWindow* window = CreateTestAppWindow("{ \"showInShelf\": true }");
+ ASSERT_TRUE(window);
+
+ // Ensure that the window created is marked as shown in shelf.
+ EXPECT_TRUE(window->show_in_shelf());
+
+ CloseAppWindow(window);
+}
+
} // namespace extensions
« no previous file with comments | « extensions/browser/app_window/app_window.cc ('k') | extensions/common/api/app_window.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698