Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.h

Issue 1811523002: Enhance chrome.app.window API with better shelf integration Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [WIP] Rebase + browser tests. Added a new map that holds all the showInShelf windows. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_EXTENSION_APP_WINDOW_LAUNCHER_CONTROLLER_ H_ 5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_EXTENSION_APP_WINDOW_LAUNCHER_CONTROLLER_ H_
6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_EXTENSION_APP_WINDOW_LAUNCHER_CONTROLLER_ H_ 6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_EXTENSION_APP_WINDOW_LAUNCHER_CONTROLLER_ H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 // Unregisters a app window with the shelf and this object. 60 // Unregisters a app window with the shelf and this object.
61 void UnregisterApp(aura::Window* window); 61 void UnregisterApp(aura::Window* window);
62 62
63 // Check if a given window is known to the launcher controller. 63 // Check if a given window is known to the launcher controller.
64 bool IsRegisteredApp(aura::Window* window); 64 bool IsRegisteredApp(aura::Window* window);
65 65
66 private: 66 private:
67 using AppControllerMap = 67 using AppControllerMap =
68 std::map<std::string, ExtensionAppWindowLauncherItemController*>; 68 std::map<std::string, ExtensionAppWindowLauncherItemController*>;
69 using WindowToAppShelfIdMap = std::map<aura::Window*, std::string>; 69 using WindowToAppShelfIdMap = std::map<aura::Window*, std::string>;
70 using WindowControllerMap =
71 std::map<aura::Window*, ExtensionAppWindowLauncherItemController*>;
70 72
71 // A set of unowned AppWindowRegistry pointers for loaded users. 73 // A set of unowned AppWindowRegistry pointers for loaded users.
72 // Note that this will only be used with multiple users in the side by side 74 // Note that this will only be used with multiple users in the side by side
73 // mode. 75 // mode.
74 std::set<extensions::AppWindowRegistry*> registry_; 76 std::set<extensions::AppWindowRegistry*> registry_;
75 77
76 // Map of app launcher id to controller. 78 // Map of app launcher id to controller.
77 AppControllerMap app_controller_map_; 79 AppControllerMap app_controller_map_;
80 WindowControllerMap window_controller_map_;
78 81
79 // Allows us to get from an aura::Window to the app shelf id. 82 // Allows us to get from an aura::Window to the app shelf id.
80 WindowToAppShelfIdMap window_to_app_shelf_id_map_; 83 WindowToAppShelfIdMap window_to_app_shelf_id_map_;
81 84
82 DISALLOW_COPY_AND_ASSIGN(ExtensionAppWindowLauncherController); 85 DISALLOW_COPY_AND_ASSIGN(ExtensionAppWindowLauncherController);
83 }; 86 };
84 87
85 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_EXTENSION_APP_WINDOW_LAUNCHER_CONTROLL ER_H_ 88 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_EXTENSION_APP_WINDOW_LAUNCHER_CONTROLL ER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698