Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 1811523002: Enhance chrome.app.window API with better shelf integration Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [WIP] Rebase + browser tests. Added a new map that holds all the showInShelf windows. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/app_window.cc
diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc
index 7294d6f8463ad5ec09290ae1129b13ae31bd4f1f..a02a9eb9f580bc4025c4c568936b50fd494527da 100644
--- a/extensions/browser/app_window/app_window.cc
+++ b/extensions/browser/app_window/app_window.cc
@@ -171,8 +171,8 @@ AppWindow::CreateParams::CreateParams()
resizable(true),
focused(true),
always_on_top(false),
- visible_on_all_workspaces(false) {
-}
+ visible_on_all_workspaces(false),
+ show_in_shelf(false) {}
AppWindow::CreateParams::CreateParams(const CreateParams& other) = default;
@@ -253,6 +253,7 @@ AppWindow::AppWindow(BrowserContext* context,
cached_always_on_top_(false),
requested_alpha_enabled_(false),
is_ime_window_(false),
+ show_in_shelf_(false),
image_loader_ptr_factory_(this) {
ExtensionsBrowserClient* client = ExtensionsBrowserClient::Get();
CHECK(!client->IsGuestSession(context) || context->IsOffTheRecord())
@@ -296,6 +297,8 @@ void AppWindow::Init(const GURL& url,
is_ime_window_ = params.is_ime_window;
+ show_in_shelf_ = params.show_in_shelf;
+
AppWindowClient* app_window_client = AppWindowClient::Get();
native_app_window_.reset(
app_window_client->CreateNativeAppWindow(this, &new_params));
« no previous file with comments | « extensions/browser/app_window/app_window.h ('k') | extensions/browser/app_window/app_window_interactive_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698