Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1810813003: update callsites for Make image factories (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

update callsites for Make image factories not forced yet, as we still have the build-guard. waiting on chrome CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1810813003 TBR= Committed: https://skia.googlesource.com/skia/+/9ce9d6772df650ceb0511f275e1a83dffa78ff72

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase #

Patch Set 6 : fix rebase #

Patch Set 7 : start to take advantage of sk_sp drawImage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+637 lines, -668 lines) Patch
M bench/DisplacementBench.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M bench/ImageBench.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M bench/MergeBench.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M bench/PDFBench.cpp View 1 2 3 4 6 chunks +8 lines, -11 lines 0 comments Download
M bench/SKPBench.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M bench/SkLinearBitmapPipelineBench.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M example/HelloWorld.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/SkLinearBitmapPipelineGM.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/all_bitmap_configs.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/astcbitmap.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/bigtileimagefilter.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M gm/bleed.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M gm/colorfilterimagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/colormatrix.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M gm/colorwheel.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/complexclip_blur_tiled.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/dftext.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M gm/displacement.cpp View 4 chunks +16 lines, -16 lines 0 comments Download
M gm/drawatlas.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M gm/drawatlascolor.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M gm/drawbitmaprect.cpp View 1 2 3 4 5 6 5 chunks +8 lines, -8 lines 0 comments Download
M gm/drawminibitmaprect.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M gm/etc1bitmap.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -6 lines 0 comments Download
M gm/filterfastbounds.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/grayscalejpg.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/image.cpp View 1 2 3 4 5 6 11 chunks +38 lines, -43 lines 0 comments Download
M gm/image_pict.cpp View 1 2 3 4 5 6 3 chunks +7 lines, -7 lines 0 comments Download
M gm/image_shader.cpp View 3 chunks +13 lines, -13 lines 0 comments Download
M gm/imagealphathreshold.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/imagefilters.cpp View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M gm/imagefilterstransformed.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M gm/imagefromyuvtextures.cpp View 2 chunks +10 lines, -12 lines 0 comments Download
M gm/imagescalealigned.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M gm/imagesource.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M gm/imagesource2.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/imagetoyuvplanes.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gm/localmatriximagefilter.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M gm/mipmap.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M gm/multipicturedraw.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M gm/ninepatchstretch.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M gm/offsetimagefilter.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M gm/perspshaders.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M gm/rectangletexture.cpp View 4 chunks +22 lines, -22 lines 0 comments Download
M gm/repeated_bitmap.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M gm/resizeimagefilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/surface.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M gm/textblobmixedsizes.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M gm/tileimagefilter.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M gm/verylargebitmap.cpp View 1 2 3 4 5 6 1 chunk +7 lines, -7 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M include/core/SkSurface.h View 2 chunks +11 lines, -2 lines 0 comments Download
M samplecode/SampleAtlas.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M samplecode/SampleFilterQuality.cpp View 6 chunks +16 lines, -30 lines 0 comments Download
M samplecode/SampleLayers.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleShip.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M samplecode/SampleTextureDomain.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/c/sk_surface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureImageGenerator.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImage_Base.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/image/SkImage_Generator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Raster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -4 lines 0 comments Download
M src/image/SkSurface_Base.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFCanon.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M src/utils/SkLua.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M tests/FlattenableFactoryToName.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterCacheTest.cpp View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M tests/ImageFrom565Bitmap.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M tests/ImageIsOpaqueTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageNewShaderTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageTest.cpp View 1 2 3 4 5 6 28 chunks +98 lines, -102 lines 0 comments Download
M tests/PDFJpegEmbedTest.cpp View 1 2 5 chunks +12 lines, -13 lines 0 comments Download
M tests/PictureTest.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M tests/ReadPixelsTest.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M tests/RecorderTest.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M tests/SerializationTest.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tests/SkColor4fTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/SkImageTest.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M tests/SkResourceCacheTest.cpp View 1 2 3 4 5 6 3 chunks +5 lines, -5 lines 0 comments Download
M tests/SpecialImageTest.cpp View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 2 16 chunks +51 lines, -47 lines 0 comments Download
M tests/TextureStorageAllocator.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/Resources.h View 2 chunks +2 lines, -1 line 0 comments Download
M tools/Resources.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/VisualBench/WrappedBenchmark.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 8 chunks +10 lines, -13 lines 0 comments Download
M tools/imgblur.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/imgslice.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skhello.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810813003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810813003/60001
4 years, 9 months ago (2016-03-17 14:14:39 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/7112)
4 years, 9 months ago (2016-03-17 14:15:50 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810813003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810813003/80001
4 years, 9 months ago (2016-03-17 14:28:29 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1214)
4 years, 9 months ago (2016-03-17 14:30:25 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810813003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810813003/100001
4 years, 9 months ago (2016-03-17 14:39:08 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810813003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810813003/120001
4 years, 9 months ago (2016-03-17 15:50:46 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 16:01:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810813003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810813003/120001
4 years, 9 months ago (2016-03-17 16:04:35 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 17:51:16 UTC) #21
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/9ce9d6772df650ceb0511f275e1a83dffa78ff72

Powered by Google App Engine
This is Rietveld 408576698