src/image/SkImage_Generator.cpp - Issue 1810813003: update callsites for Make image factories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/image/SkImage_Generator.cpp

Issue 1810813003: update callsites for Make image factories (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: start to take advantage of sk_sp drawImage Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/image/SkImage_Generator.cpp

diff --git a/src/image/SkImage_Generator.cpp b/src/image/SkImage_Generator.cpp

index 62b492e2881cab8c585174b3ca26c3d613bc7e30..f8af12a612d22272935fc884196d4c6e01bd63ad 100644

--- a/src/image/SkImage_Generator.cpp

+++ b/src/image/SkImage_Generator.cpp

@@ -86,7 +86,7 @@ sk_sp<SkImage> SkImage_Generator::onMakeSubset(const SkIRect& subset) const {

surface->getCanvas()->clear(0);

surface->getCanvas()->drawImage(this, SkIntToScalar(-subset.x()), SkIntToScalar(-subset.y()),

nullptr);

- return sk_sp<SkImage>(surface->newImageSnapshot());

+ return surface->makeImageSnapshot();

}

sk_sp<SkImage> SkImage::MakeFromGenerator(SkImageGenerator* generator, const SkIRect* subset) {

« no previous file with comments | « src/image/SkImage_Base.h ('k') | src/image/SkImage_Raster.cpp » ('j') | no next file with comments »