Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 180953009: Revert 168554 "Reduce compositing update in Silk's toggle_drawer..." (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Revert 168554 "Reduce compositing update in Silk's toggle_drawer..." This CL broke win builds: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28dbg%29/builds/47919 > Reduce compositing update in Silk's toggle_drawer by 20% > > This reduces the amount of time spent in compositing update for Silk's > toggle_drawer test case by 20%. Previously, we would update the geometry for > every composited layer mapping during every compositing update, regardless of > whether any of the inputs to updateGraphicsLayerGeometry had changed. This CL > introduces dirty bits on CompositedLayerMapping to track which RenderLayers > underwent a change that could have resulted in changes during > updateGraphicsLayerGeometry. > > This CL takes a basic approach, which is sufficient for toggle_drawer. > Specifically, if a RenderLayer changes style, we mark its > CompositedLayerMapping (and any ancestors and decendants) as needing a geometry > update. If we go through layout or scroll, we trigger a forced update, which > updates the geometry of all graphics layers. > > Over time, we can improve this system to track dirtiness during layout. We > might also be able to avoid marking every ancestor dirty if we removed the > downward tree walks during updateGraphicsLayerGeometry. Instead, we could > compute the descendant-dependant information in an earlier phase and detect > whether it changed directly. > > R=esprehn@chromium.org, ojan@chromium.org > > Review URL: https://codereview.chromium.org/183763016 TBR=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -112 lines) Patch
M trunk/Source/core/rendering/RenderLayer.cpp View 6 chunks +1 line, -26 lines 0 comments Download
M trunk/Source/core/rendering/compositing/CompositedLayerMapping.h View 4 chunks +7 lines, -13 lines 0 comments Download
M trunk/Source/core/rendering/compositing/CompositedLayerMapping.cpp View 5 chunks +4 lines, -34 lines 0 comments Download
M trunk/Source/core/rendering/compositing/GraphicsLayerUpdater.h View 1 chunk +3 lines, -8 lines 0 comments Download
M trunk/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp View 7 chunks +10 lines, -13 lines 0 comments Download
M trunk/Source/core/rendering/compositing/RenderLayerCompositor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/Source/core/rendering/compositing/RenderLayerCompositor.cpp View 6 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
6 years, 9 months ago (2014-03-06 02:47:37 UTC) #1
haraken
6 years, 9 months ago (2014-03-06 02:48:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r168556.

Powered by Google App Engine
This is Rietveld 408576698