Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

Issue 1809073003: [DevTools] Move callFunctionOn to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-evaluate-v2
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
index 439dcfcc88491b28c87787ccba35d393268ac1e9..8155389b5581a02d86633c3c9124890f20323897 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
@@ -34,7 +34,6 @@ InspectorTest.evaluateInConsoleAndDump = function(code, callback)
function mycallback(text)
{
text = text.replace(/\bVM\d+/g, "VM");
- text = text.replace(/(?:InjectedScript\.)?_?evaluate\w* @ VM:\d+/g, "");
InspectorTest.addResult(code + " = " + text);
callback(text);
}
@@ -46,12 +45,6 @@ InspectorTest.prepareConsoleMessageText = function(messageElement, consoleMessag
var messageText = messageElement.deepTextContent().replace(/\u200b/g, "");
// Replace scriptIds with generic scriptId string to avoid flakiness.
messageText = messageText.replace(/VM\d+/g, "VM");
- // Strip out InjectedScript line numbers from stack traces to avoid rebaselining each time InjectedScriptSource is edited.
- messageText = messageText.replace(/(?:InjectedScript\.)?_?evaluate\w* @ VM:\d+/g, "");
- // Strip out InjectedScript line numbers from console message anchor.
- var functionName = consoleMessage && consoleMessage.stackTrace && consoleMessage.stackTrace.callFrames[0] && consoleMessage.stackTrace.callFrames[0].functionName || "";
- if (functionName.indexOf("evaluate") !== -1)
- messageText = messageText.replace(/\bVM:\d+/, ""); // Only first replace.
if (messageText.startsWith("Navigated to")) {
var fileName = messageText.split(" ").pop().split("/").pop();
messageText = "Navigated to " + fileName;
@@ -133,7 +126,6 @@ InspectorTest.formatterIgnoreStackFrameUrls = function(messageFormatter, node)
{
var buffer = string.replace(/\u200b/g, "");
buffer = buffer.replace(/VM\d+/g, "VM");
- buffer = buffer.replace(/(?:InjectedScript\.)?_?evaluate\w* @ VM:\d+/g, "");
return buffer.replace(/^\s+at [^\]]+(]?)$/, "$1");
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698