Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1808463002: Don't mark a WebMediaPlayer as idle until it has size and first frame. (Closed)

Created:
4 years, 9 months ago by DaleCurtis
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Don't mark a WebMediaPlayer as idle until it has size and first frame. Slow connections, large MediaSource appends, or open-in-background can result in large delays from when the WMP is constructed until it reaches a state appropriate for suspension. Waiting until we have the first frame and size information to mark a player as idle should resolve any issues around suspending too early. BUG=592706 TEST=fixed unittests. Suspend does not occur w/ open-in-background. Review URL: https://codereview.chromium.org/1796403002 Cr-Commit-Position: refs/heads/master@{#381156} (cherry picked from commit 8e4dc68fcf8ab6f808e2b819e334098fcfd2f59f) Committed: https://chromium.googlesource.com/chromium/src/+/4a00b19754bfea0165c3fe027a77d8af1c4e643f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/media/renderer_webmediaplayer_delegate.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_delegate.h View 1 chunk +4 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 9 months ago (2016-03-15 18:32:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4a00b19754bfea0165c3fe027a77d8af1c4e643f.

Powered by Google App Engine
This is Rietveld 408576698