Don't mark a WebMediaPlayer as idle until it has size and first frame.

Don't mark a WebMediaPlayer as idle until it has size and first frame.

Slow connections, large MediaSource appends, or open-in-background can
result in large delays from when the WMP is constructed until it reaches
a state appropriate for suspension.

Waiting until we have the first frame and size information to mark a
player as idle should resolve any issues around suspending too early.

BUG=592706
TEST=fixed unittests. Suspend does not occur w/ open-in-background.

Committed: https://crrev.com/8e4dc68fcf8ab6f808e2b819e334098fcfd2f59f
Cr-Commit-Position: refs/heads/master@{#381156}

[DaleCurtis, 2016-03-15 00:46:44]

dalecurtis@chromium.org changed reviewers:
+ sandersd@chromium.org, wolenetz@chromium.org

[sandersd (OOO until July 31), 2016-03-15 00:53:43]

lgtm

[wolenetz, 2016-03-15 01:08:24]

Mostly good. Just a WMPA case that's concerning:

https://codereview.chromium.org/1796403002/diff/1/content/renderer/media/andr...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/1796403002/diff/1/content/renderer/media/andr...
content/renderer/media/android/webmediaplayer_android.cc:972: // If we're paused
after we receive metadata for the first time, tell the
For MSE midstream configchange that changes the width or height, would this new
code start a 15-second timer on the delegate that might not get canceled across
the continually, actually still playing, configchange?

[wolenetz, 2016-03-15 01:11:19]

https://codereview.chromium.org/1796403002/diff/1/content/renderer/media/andr...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/1796403002/diff/1/content/renderer/media/andr...
content/renderer/media/android/webmediaplayer_android.cc:972: // If we're paused
after we receive metadata for the first time, tell the
On 2016/03/15 01:08:24, wolenetz wrote:
> For MSE midstream configchange that changes the width or height, would this
new
> code start a 15-second timer on the delegate that might not get canceled
across
> the continually, actually still playing, configchange?

Dale pointed out this block happens only once (if !video_weblayer_).
So no problem here.

[wolenetz, 2016-03-15 01:11:22]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2016-03-15 01:11:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1796403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1796403002/1

[wolenetz, 2016-03-15 01:11:41]

Oh, and LGTM :)

[commit-bot: I haz the power, 2016-03-15 02:30:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-15 02:31:31]

Description was changed from

==========
Don't mark a WebMediaPlayer as idle until it has size and first frame.

Slow connections, large MediaSource appends, or open-in-background can
result in large delays from when the WMP is constructed until it reaches
a state appropriate for suspension.

Waiting until we have the first frame and size information to mark a
player as idle should resolve any issues around suspending too early.

BUG=592706
TEST=fixed unittests. Suspend does not occur w/ open-in-background.
==========

to

==========
Don't mark a WebMediaPlayer as idle until it has size and first frame.

Slow connections, large MediaSource appends, or open-in-background can
result in large delays from when the WMP is constructed until it reaches
a state appropriate for suspension.

Waiting until we have the first frame and size information to mark a
player as idle should resolve any issues around suspending too early.

BUG=592706
TEST=fixed unittests. Suspend does not occur w/ open-in-background.

Committed: https://crrev.com/8e4dc68fcf8ab6f808e2b819e334098fcfd2f59f
Cr-Commit-Position: refs/heads/master@{#381156}
==========

[commit-bot: I haz the power, 2016-03-15 02:31:32]

Patchset 1 (id:??) landed as
https://crrev.com/8e4dc68fcf8ab6f808e2b819e334098fcfd2f59f
Cr-Commit-Position: refs/heads/master@{#381156}