Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: media/blink/webmediaplayer_delegate.h

Issue 1808463002: Don't mark a WebMediaPlayer as idle until it has size and first frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_delegate.h
diff --git a/media/blink/webmediaplayer_delegate.h b/media/blink/webmediaplayer_delegate.h
index 7ae31df780b888b8248e41d92e5fd338a3c35e23..cfc3f678307f59f361aaae598dcc74801fcbcb05 100644
--- a/media/blink/webmediaplayer_delegate.h
+++ b/media/blink/webmediaplayer_delegate.h
@@ -43,7 +43,10 @@ class WebMediaPlayerDelegate {
bool is_remote,
base::TimeDelta duration) = 0;
- // The specified player stopped playing media.
+ // The specified player stopped playing media. This may be called at any time
+ // with or without a DidPlay() having previously occurred. Calling this will
+ // cause the delegate to be registered for idle suspension. I.e., after some
+ // time elapses without a DidPlay(), OnSuspendRequested() will be issued.
virtual void DidPause(int delegate_id, bool reached_end_of_stream) = 0;
// The specified player was destroyed or suspended. This may be called
« no previous file with comments | « content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698