content/renderer/media/renderer_webmediaplayer_delegate.cc - Issue 1808463002: Don't mark a WebMediaPlayer as idle until it has size and first frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/renderer_webmediaplayer_delegate.cc

Issue 1808463002: Don't mark a WebMediaPlayer as idle until it has size and first frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/android/webmediaplayer_android.cc ('k') | content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/renderer_webmediaplayer_delegate.cc

diff --git a/content/renderer/media/renderer_webmediaplayer_delegate.cc b/content/renderer/media/renderer_webmediaplayer_delegate.cc

index 9966382c37291edb9e3ccef5c9b8359f136c9682..f139728d84d4b5e1c470c887a9952f3bcad11a53 100644

--- a/content/renderer/media/renderer_webmediaplayer_delegate.cc

+++ b/content/renderer/media/renderer_webmediaplayer_delegate.cc

@@ -30,9 +30,7 @@ RendererWebMediaPlayerDelegate::RendererWebMediaPlayerDelegate(

RendererWebMediaPlayerDelegate::~RendererWebMediaPlayerDelegate() {}

int RendererWebMediaPlayerDelegate::AddObserver(Observer* observer) {

- const int delegate_id = id_map_.Add(observer);

- AddIdleDelegate(delegate_id);

- return delegate_id;

+ return id_map_.Add(observer);

}

void RendererWebMediaPlayerDelegate::RemoveObserver(int delegate_id) {