Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

- We may use *CHECK* macros instead of *ASSERT* macros.
- We may use *LOG* macros instead of WTF_LOG.

- Update the following files as examples:
  - HashTable.h
  - RefCountedLeakCounter.cpp
    It uses VLOG(0) because the log channel was enabled by default.
  - StringBuilder.*
  - TextCodecICU.cpp
  - TextEncodingRegistry.cpp

- Move WTFTestPrinters implementation to WTFString.cpp and AtomicString.cpp in
  order to pass String and AtomicString to base/logging macros.
  Also, this CL removes wtf_unittest_helpers build target.

This CL has no behavior changes.

Committed: https://crrev.com/d4640bcf2f2502deb74c019e40d1cd1ae32da64d
Cr-Commit-Position: refs/heads/master@{#381919}

[tkent, 2016-03-17 08:30:45]

tkent@chromium.org changed reviewers:
+ esprehn@chromium.org

[tkent, 2016-03-17 08:30:45]

esprehn@, would you review this please?

[esprehn, 2016-03-17 15:29:54]

Why do you want to do this? Changing deps without. Source doesn't make sense.

[tkent, 2016-03-17 20:53:43]

On 2016/03/17 at 15:29:54, esprehn wrote:
> Why do you want to do this? Changing deps without. Source doesn't make sense.

This is just a preparation to use base/logging.h globally.  We'd like to use
*LOG*, *CHECK*, NOTREACHED(), and NOTIMPLEMENTED() in Blink.


Context:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Vc01D5Vpkx8

[esprehn, 2016-03-17 22:52:57]

On 2016/03/17 at 20:53:43, tkent wrote:
> On 2016/03/17 at 15:29:54, esprehn wrote:
> > Why do you want to do this? Changing deps without. Source doesn't make
sense.
> 
> This is just a preparation to use base/logging.h globally.  We'd like to use
*LOG*, *CHECK*, NOTREACHED(), and NOTIMPLEMENTED() in Blink.
> 
> 
> Context:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Vc01D5Vpkx8

I think we want a WTF wrapper around this, we probably want macros to make
logging our strings and such friendlier. Also we should always land patches with
real changes when changing DEPS, so this patch should also add usages.

[tkent, 2016-03-18 02:30:44]

Description was changed from

==========
Allow base/logging.h in third_party/WebKit/Source/.

This CL has no behavior changes.

NOTRY=true
==========

to

==========
Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

- We may use *CHECK* macros instead of *ASSERT* macros.
- We may use *LOG* macros instead of WTF_LOG.

- Update the following files as examples:
  - HashTable.h
  - RefCountedLeakCounter.cpp
  - StringBuilder.*
  - TextCodecICU.cpp
  - TextEncodingRegistry.cpp

- Move WTFTestPrinters implementation to WTFString.cpp and AtomicString.cpp.
  Also, this CL removes wtf_unittest_helpers build target.

This CL has no behavior changes.
==========

[tkent, 2016-03-18 02:33:53]

Patchset #2 (id:20001) has been deleted

[tkent, 2016-03-18 02:35:03]

Description was changed from

==========
Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

- We may use *CHECK* macros instead of *ASSERT* macros.
- We may use *LOG* macros instead of WTF_LOG.

- Update the following files as examples:
  - HashTable.h
  - RefCountedLeakCounter.cpp
  - StringBuilder.*
  - TextCodecICU.cpp
  - TextEncodingRegistry.cpp

- Move WTFTestPrinters implementation to WTFString.cpp and AtomicString.cpp.
  Also, this CL removes wtf_unittest_helpers build target.

This CL has no behavior changes.
==========

to

==========
Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

- We may use *CHECK* macros instead of *ASSERT* macros.
- We may use *LOG* macros instead of WTF_LOG.

- Update the following files as examples:
  - HashTable.h
  - RefCountedLeakCounter.cpp
  - StringBuilder.*
  - TextCodecICU.cpp
  - TextEncodingRegistry.cpp

- Move WTFTestPrinters implementation to WTFString.cpp and AtomicString.cpp in
  order to pass String and AtomicString to base/logging macros.
  Also, this CL removes wtf_unittest_helpers build target.

This CL has no behavior changes.
==========

[tkent, 2016-03-18 02:40:40]

> I think we want a WTF wrapper around this, we probably want macros to make
logging our strings and such friendlier. Also we should always land patches with
real changes when changing DEPS, so this patch should also add usages.

Ok, though I'm not a fan of just wrapping a base header with a WTF header, it
makes sense in this case because Chromium have no
ASSERT_WITH_SECURITY_IMPLICATION equivalent.  So, I make Assertions.h wraps
base/logging.h.
I added some real usage, and add support of String logging.

Please take another look at this.

[esprehn, 2016-03-18 04:58:25]

On 2016/03/18 at 02:40:40, tkent wrote:
> > I think we want a WTF wrapper around this, we probably want macros to make
logging our strings and such friendlier. Also we should always land patches with
real changes when changing DEPS, so this patch should also add usages.
> 
> Ok, though I'm not a fan of just wrapping a base header with a WTF header, it
makes sense in this case because Chromium have no
ASSERT_WITH_SECURITY_IMPLICATION equivalent.  So, I make Assertions.h wraps
base/logging.h.
> I added some real usage, and add support of String logging.
> 
> Please take another look at this.

The purpose of requiring the wrapping headers is that it forces you to think
about how your base API will interact with WTF.

[esprehn, 2016-03-18 04:58:31]

https://codereview.chromium.org/1807853003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Assertions.h (right):

https://codereview.chromium.org/1807853003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Assertions.h:310: // ALLOW_UNUSED_LOCAL().
Why do you need to use ALLOW_UNUSED_LOCAL ?

https://codereview.chromium.org/1807853003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Assertions.h:395: //  - LOG(FATAL) for
RELEASE_ASSERT_NOT_REACHED().
LOG(FATAL) is less clear, we should add a release version of NOTREACHED() here
or in base macros.

https://codereview.chromium.org/1807853003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/text/WTFString.cpp (right):

https://codereview.chromium.org/1807853003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/text/WTFString.cpp:1227: if (character >= 0x20 &&
character < 0x7F) {
This is just isASCII ?

[tkent, 2016-03-18 05:19:21]

I uploaded a new patch.

https://codereview.chromium.org/1807853003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Assertions.h (right):

https://codereview.chromium.org/1807853003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Assertions.h:310: // ALLOW_UNUSED_LOCAL().
On 2016/03/18 at 04:58:30, esprehn wrote:
> Why do you need to use ALLOW_UNUSED_LOCAL ?

to avoid "unused variable" warning in release build.

https://codereview.chromium.org/1807853003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Assertions.h:395: //  - LOG(FATAL) for
RELEASE_ASSERT_NOT_REACHED().
On 2016/03/18 at 04:58:31, esprehn wrote:
> LOG(FATAL) is less clear, we should add a release version of NOTREACHED() here
or in base macros.

ok, I added RELEASE_NOTREACHED() here.

https://codereview.chromium.org/1807853003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/text/WTFString.cpp (right):

https://codereview.chromium.org/1807853003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/text/WTFString.cpp:1227: if (character >= 0x20 &&
character < 0x7F) {
On 2016/03/18 at 04:58:31, esprehn wrote:
> This is just isASCII ?

I changed it to isASCIIPrintable()

[esprehn, 2016-03-18 05:20:55]

lgtm

[tkent, 2016-03-18 05:22:34]

Description was changed from

==========
Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

- We may use *CHECK* macros instead of *ASSERT* macros.
- We may use *LOG* macros instead of WTF_LOG.

- Update the following files as examples:
  - HashTable.h
  - RefCountedLeakCounter.cpp
  - StringBuilder.*
  - TextCodecICU.cpp
  - TextEncodingRegistry.cpp

- Move WTFTestPrinters implementation to WTFString.cpp and AtomicString.cpp in
  order to pass String and AtomicString to base/logging macros.
  Also, this CL removes wtf_unittest_helpers build target.

This CL has no behavior changes.
==========

to

==========
Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

- We may use *CHECK* macros instead of *ASSERT* macros.
- We may use *LOG* macros instead of WTF_LOG.

- Update the following files as examples:
  - HashTable.h
  - RefCountedLeakCounter.cpp
    It uses VLOG(0) because the log channel was enabled by default.
  - StringBuilder.*
  - TextCodecICU.cpp
  - TextEncodingRegistry.cpp

- Move WTFTestPrinters implementation to WTFString.cpp and AtomicString.cpp in
  order to pass String and AtomicString to base/logging macros.
  Also, this CL removes wtf_unittest_helpers build target.

This CL has no behavior changes.
==========

[tkent, 2016-03-18 06:17:33]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-03-18 06:17:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807853003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807853003/60001

[commit-bot: I haz the power, 2016-03-18 07:33:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 07:33:24]

Failed to apply patch for third_party/WebKit/Source/wtf/Assertions.h:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/wtf/Assertions.h:213
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/wtf/Assertions.h' with conflicts.
  U third_party/WebKit/Source/wtf/Assertions.h

Patch:       third_party/WebKit/Source/wtf/Assertions.h
Index: third_party/WebKit/Source/wtf/Assertions.h
diff --git a/third_party/WebKit/Source/wtf/Assertions.h
b/third_party/WebKit/Source/wtf/Assertions.h
index
a5fcb9a65f919a0f1d1118732c7cadc551f4b3a0..ef8c0df59f4e1d1dc07c3612e59acabcbbfbc580
100644
--- a/third_party/WebKit/Source/wtf/Assertions.h
+++ b/third_party/WebKit/Source/wtf/Assertions.h
@@ -40,6 +40,7 @@
 
 */
 
+#include "base/logging.h"
 #include "wtf/Compiler.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/WTFExport.h"
@@ -213,11 +214,13 @@ using WTF::ScopedLogger;
 
 #endif
 
-/* ASSERT, ASSERT_NOT_REACHED, ASSERT_UNUSED
-
-  These macros are compiled out of release builds.
-  Expressions inside them are evaluated in debug builds only.
-*/
+// ASSERT, ASSERT_NOT_REACHED, ASSERT_UNUSED
+//  These macros are compiled out of release builds.
+//  Expressions inside them are evaluated in debug builds only.
+//  They are deprecated. We should use:
+//    - DCHECK() for ASSERT()
+//    - NOTREACHED() for ASSERT_NOT_REACHED()
+//    - DCHECK() and ALLOW_UNUSED_LOCAL() for ASSERT_UNUSED().
 #if OS(WIN)
 /* FIXME: Change to use something other than ASSERT to avoid this conflict with
the underlying platform */
 #undef ASSERT
@@ -289,8 +292,8 @@ using WTF::ScopedLogger;
 #define ENABLE_SECURITY_ASSERT 0
 #endif
 
-/* ASSERT_WITH_MESSAGE */
-
+// ASSERT_WITH_MESSAGE
+// This is deprecated.  We should use DCHECK() << "message".
 #if ASSERT_MSG_DISABLED
 #define ASSERT_WITH_MESSAGE(assertion, ...) ((void)0)
 #else
@@ -302,8 +305,9 @@ using WTF::ScopedLogger;
 while (0)
 #endif
 
-/* ASSERT_WITH_MESSAGE_UNUSED */
-
+// ASSERT_WITH_MESSAGE_UNUSED
+// This is deprecated.  We should use DCHECK() << "message" and
+// ALLOW_UNUSED_LOCAL().
 #if ASSERT_MSG_DISABLED
 #define ASSERT_WITH_MESSAGE_UNUSED(variable, assertion, ...) ((void)variable)
 #else
@@ -332,8 +336,8 @@ while (0)
 
 #endif
 
-/* FATAL */
-
+// FATAL
+// This is deprecated.  We should use DLOG(FATAL) << ...
 #if FATAL_DISABLED
 #define FATAL(...) ((void)0)
 #else
@@ -343,16 +347,17 @@ while (0)
 } while (0)
 #endif
 
-/* WTF_LOG_ERROR */
-
+// WTF_LOG_ERROR
+// This is deprecated.  We should use DLOG(ERROR) << ...
 #if ERROR_DISABLED
 #define WTF_LOG_ERROR(...) ((void)0)
 #else
 #define WTF_LOG_ERROR(...) WTFReportError(__FILE__, __LINE__,
WTF_PRETTY_FUNCTION, __VA_ARGS__)
 #endif
 
-/* WTF_LOG */
-
+// WTF_LOG
+// This is deprecated.  Should be replaced with DVLOG(verboselevel), which
works
+// only in debug build, or VLOG(verboselevel), which works in release build
too.
 #if LOG_DISABLED
 #define WTF_LOG(channel, ...) ((void)0)
 #else
@@ -384,7 +389,10 @@ static inline void UNREACHABLE_FOR_PLATFORM()
    Please sure to file bugs for these failures using the security template:
       http://code.google.com/p/chromium/issues/entry?template=Security%20Bug
 */
-
+// RELEASE_ASSERT* are deprecated.  We should use:
+//  - CHECK() for RELEASE_ASSERT()
+//  - CHECK() << message for RELEASE_ASSERT_WITH_MESSAGE()
+//  - RELEASE_NOTREACHED() for RELEASE_ASSERT_NOT_REACHED().
 #if ENABLE(ASSERT)
 #define RELEASE_ASSERT(assertion) ASSERT(assertion)
 #define RELEASE_ASSERT_WITH_MESSAGE(assertion, ...)
ASSERT_WITH_MESSAGE(assertion, __VA_ARGS__)
@@ -394,6 +402,8 @@ static inline void UNREACHABLE_FOR_PLATFORM()
 #define RELEASE_ASSERT_WITH_MESSAGE(assertion, ...) RELEASE_ASSERT(assertion)
 #define RELEASE_ASSERT_NOT_REACHED() IMMEDIATE_CRASH()
 #endif
+// TODO(tkent): Move this to base/logging.h?
+#define RELEASE_NOTREACHED() LOG(FATAL)
 
 /* DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES */

[commit-bot: I haz the power, 2016-03-18 07:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[tkent, 2016-03-18 07:45:33]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-03-18 07:45:34]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1807853003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-18 07:45:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807853003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807853003/80001

[commit-bot: I haz the power, 2016-03-18 09:32:11]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-03-18 09:33:26]

Description was changed from

==========
Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

- We may use *CHECK* macros instead of *ASSERT* macros.
- We may use *LOG* macros instead of WTF_LOG.

- Update the following files as examples:
  - HashTable.h
  - RefCountedLeakCounter.cpp
    It uses VLOG(0) because the log channel was enabled by default.
  - StringBuilder.*
  - TextCodecICU.cpp
  - TextEncodingRegistry.cpp

- Move WTFTestPrinters implementation to WTFString.cpp and AtomicString.cpp in
  order to pass String and AtomicString to base/logging macros.
  Also, this CL removes wtf_unittest_helpers build target.

This CL has no behavior changes.
==========

to

==========
Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

- We may use *CHECK* macros instead of *ASSERT* macros.
- We may use *LOG* macros instead of WTF_LOG.

- Update the following files as examples:
  - HashTable.h
  - RefCountedLeakCounter.cpp
    It uses VLOG(0) because the log channel was enabled by default.
  - StringBuilder.*
  - TextCodecICU.cpp
  - TextEncodingRegistry.cpp

- Move WTFTestPrinters implementation to WTFString.cpp and AtomicString.cpp in
  order to pass String and AtomicString to base/logging macros.
  Also, this CL removes wtf_unittest_helpers build target.

This CL has no behavior changes.

Committed: https://crrev.com/d4640bcf2f2502deb74c019e40d1cd1ae32da64d
Cr-Commit-Position: refs/heads/master@{#381919}
==========

[commit-bot: I haz the power, 2016-03-18 09:33:27]

Patchset 4 (id:??) landed as
https://crrev.com/d4640bcf2f2502deb74c019e40d1cd1ae32da64d
Cr-Commit-Position: refs/heads/master@{#381919}

[Nico, 2016-03-18 14:34:24]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-03-18 14:34:25]

https://codereview.chromium.org/1807853003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/HashTable.h (right):

https://codereview.chromium.org/1807853003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/HashTable.h:290: ALLOW_UNUSED_LOCAL(container);
Is this needed? container is used (assigned to m_container), and it's just a
parameter, not a local

[xhwang, 2016-03-21 17:03:24]

xhwang@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2016-03-21 17:03:25]

Is there a bug to track the migration work in our codebase?

[xhwang, 2016-03-21 17:26:10]

Also, is this only for third_party/WebKit/Source/wtf? Can I use base/logging.h
in third_party/WebKit/Source/modules?

[tkent, 2016-03-22 02:09:34]

> Is there a bug to track the migration work in our codebase?

I filed crbug.com/596760 .

> Also, is this only for third_party/WebKit/Source/wtf? Can I use base/logging.h
in third_party/WebKit/Source/modules?

No.  You may use base/logging.h macros by including "wtf/Assertions.h", but you
should not include base/logging.h directly.

[Nico, 2016-03-22 02:56:21]

https://codereview.chromium.org/1807853003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/HashTable.h (right):

https://codereview.chromium.org/1807853003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/HashTable.h:290: ALLOW_UNUSED_LOCAL(container);
On 2016/03/18 14:34:25, Nico wrote:
> Is this needed? container is used (assigned to m_container), and it's just a
> parameter, not a local

(Did you see this?)

[tkent, 2016-03-22 03:04:17]

On 2016/03/22 at 02:56:21, thakis wrote:
>
https://codereview.chromium.org/1807853003/diff/80001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/wtf/HashTable.h (right):
> 
>
https://codereview.chromium.org/1807853003/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/wtf/HashTable.h:290: ALLOW_UNUSED_LOCAL(container);
> On 2016/03/18 14:34:25, Nico wrote:
> > Is this needed? container is used (assigned to m_container), and it's just a
> > parameter, not a local
> 
> (Did you see this?)

Oh, I forgot to send a draft :)

[tkent, 2016-03-22 03:04:22]

https://codereview.chromium.org/1807853003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/HashTable.h (right):

https://codereview.chromium.org/1807853003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/HashTable.h:290: ALLOW_UNUSED_LOCAL(container);
On 2016/03/18 at 14:34:25, Nico wrote:
> Is this needed? container is used (assigned to m_container), and it's just a
parameter, not a local

It's used only if ENABLE(SECURITY_ASSERT).
I remember a unused parameter caused a build error in WebKit.  It might not be
same in Chromium/Blink.

[xhwang, 2016-03-22 17:03:37]

On 2016/03/22 02:09:34, tkent wrote:
> > Is there a bug to track the migration work in our codebase?
> 
> I filed crbug.com/596760 .
> 
> > Also, is this only for third_party/WebKit/Source/wtf? Can I use
base/logging.h
> in third_party/WebKit/Source/modules?
> 
> No.  You may use base/logging.h macros by including "wtf/Assertions.h", but
you
> should not include base/logging.h directly.

When can we start to use base/strings/* etc in
third_party/WebKit/Source/modules?

[esprehn, 2016-03-22 18:09:01]

On 2016/03/22 at 17:03:37, xhwang wrote:
> On 2016/03/22 02:09:34, tkent wrote:
> > > Is there a bug to track the migration work in our codebase?
> > 
> > I filed crbug.com/596760 .
> > 
> > > Also, is this only for third_party/WebKit/Source/wtf? Can I use
base/logging.h
> > in third_party/WebKit/Source/modules?
> > 
> > No.  You may use base/logging.h macros by including "wtf/Assertions.h", but
you
> > should not include base/logging.h directly.
> 
> When can we start to use base/strings/* etc in
third_party/WebKit/Source/modules?

Blink uses WTF::String, base/strings will not be available. If something is
missing in the WTF String library you should file a bug and we can add it.

[xhwang, 2016-03-22 18:25:06]

On 2016/03/22 18:09:01, esprehn wrote:
> On 2016/03/22 at 17:03:37, xhwang wrote:
> > On 2016/03/22 02:09:34, tkent wrote:
> > > > Is there a bug to track the migration work in our codebase?
> > > 
> > > I filed crbug.com/596760 .
> > > 
> > > > Also, is this only for third_party/WebKit/Source/wtf? Can I use
> base/logging.h
> > > in third_party/WebKit/Source/modules?
> > > 
> > > No.  You may use base/logging.h macros by including "wtf/Assertions.h",
but
> you
> > > should not include base/logging.h directly.
> > 
> > When can we start to use base/strings/* etc in
> third_party/WebKit/Source/modules?
> 
> Blink uses WTF::String, base/strings will not be available. If something is
> missing in the WTF String library you should file a bug and we can add it.

Maybe I should ask my question more directly :) What's the best way to hex
encode a String or char* in Blink? Like
https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/strin...

[tkent, 2016-03-22 20:37:31]

On 2016/03/22 at 18:25:06, xhwang wrote:
> Maybe I should ask my question more directly :) What's the best way to hex
encode a String or char* in Blink? Like
https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/strin...

I don't know a function to encode binary buffer in Blink.
If you want to encode binary buffer in order to pass it to LOG/CHECK stream, I
recommend to add ostream printer for a class including the binary buffer like:
    std::ostream& operator<<(std::ostream&, const ClassIncludingBinaryBuffer&);
    LOG(ERROR) << "Failed; " << *this;

[esprehn, 2016-03-22 21:08:42]

Blink has appendByteAsHex, we can add a StringToHex method to the HexNumber.h
header if needed.