Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: third_party/WebKit/Source/wtf/text/StringBuilder.h

Issue 1807853003: Deprecate some macros in wtf/Assertions.h in favor of base/logging.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/text/StringBuilder.h
diff --git a/third_party/WebKit/Source/wtf/text/StringBuilder.h b/third_party/WebKit/Source/wtf/text/StringBuilder.h
index ba58742831c72491f5eb3b1adb1935c07025b386..73cc2655e83cf11ef4f42de10b749a4c8ea74ab4 100644
--- a/third_party/WebKit/Source/wtf/text/StringBuilder.h
+++ b/third_party/WebKit/Source/wtf/text/StringBuilder.h
@@ -207,7 +207,7 @@ public:
if (!m_string.isNull())
return AtomicString(m_string);
- ASSERT(m_buffer);
+ DCHECK(m_buffer);
return AtomicString(m_buffer.get(), 0, m_length);
}
@@ -241,23 +241,23 @@ public:
const LChar* characters8() const
{
- ASSERT(m_is8Bit);
+ DCHECK(m_is8Bit);
if (!m_length)
return 0;
if (!m_string.isNull())
return m_string.characters8();
- ASSERT(m_buffer);
+ DCHECK(m_buffer);
return m_buffer->characters8();
}
const UChar* characters16() const
{
- ASSERT(!m_is8Bit);
+ DCHECK(!m_is8Bit);
if (!m_length)
return 0;
if (!m_string.isNull())
return m_string.characters16();
- ASSERT(m_buffer);
+ DCHECK(m_buffer);
return m_buffer->characters16();
}
@@ -309,14 +309,14 @@ private:
template <>
ALWAYS_INLINE LChar* StringBuilder::getBufferCharacters<LChar>()
{
- ASSERT(m_is8Bit);
+ DCHECK(m_is8Bit);
return m_bufferCharacters8;
}
template <>
ALWAYS_INLINE UChar* StringBuilder::getBufferCharacters<UChar>()
{
- ASSERT(!m_is8Bit);
+ DCHECK(!m_is8Bit);
return m_bufferCharacters16;
}

Powered by Google App Engine
This is Rietveld 408576698