Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

third_party/WebKit/Source/wtf/HashTable.h

 /*
  * Copyright (C) 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008 David Levin <levin@chromium.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 269 matching lines @@
 template <typename HashTableType, typename ValueType> struct HashTableAddResult final {
     STACK_ALLOCATED();
     HashTableAddResult(const HashTableType* container, ValueType* storedValue, bool isNewEntry)
         : storedValue(storedValue)
         , isNewEntry(isNewEntry)
 #if ENABLE(SECURITY_ASSERT)
         , m_container(container)
         , m_containerModifications(container->modifications())
 #endif
     {
-        ASSERT_UNUSED(container, container);
+        ALLOW_UNUSED_LOCAL(container);

[Nico, 2016/03/18 14:34:25]

Is this needed? container is used (assigned to m_container), and it's just a
parameter, not a local

[Nico, 2016/03/22 02:56:21]

(Did you see this?)

[tkent, 2016/03/22 03:04:21]

It's used only if ENABLE(SECURITY_ASSERT).
I remember a unused parameter caused a build error in WebKit.  It might not be
same in Chromium/Blink.

+        DCHECK(container);
     }
 
     ValueType* storedValue;
     bool isNewEntry;
 
 #if ENABLE(SECURITY_ASSERT)
     ~HashTableAddResult()
     {
         // If rehash happened before accessing storedValue, it's
         // use-after-free. Any modification may cause a rehash, so we check for
@@ skipping 1222 matching lines @@
     CollectionIterator end(toBeRemoved.end());
     for (CollectionIterator it(toBeRemoved.begin()); it != end; ++it)
         collection.remove(*it);
 }
 
 } // namespace WTF
 
 #include "wtf/HashIterators.h"
 
 #endif // WTF_HashTable_h