Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Unified Diff: third_party/WebKit/Source/wtf/HashTable.h

Issue 1807853003: Deprecate some macros in wtf/Assertions.h in favor of base/logging.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/DEPS ('k') | third_party/WebKit/Source/wtf/RefCountedLeakCounter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/HashTable.h
diff --git a/third_party/WebKit/Source/wtf/HashTable.h b/third_party/WebKit/Source/wtf/HashTable.h
index 373dbda75bb434f7c78da8374f61bc68e46cc688..aad25e7c29840c7cec0016c97746ae89fe419eee 100644
--- a/third_party/WebKit/Source/wtf/HashTable.h
+++ b/third_party/WebKit/Source/wtf/HashTable.h
@@ -287,7 +287,8 @@ template <typename HashTableType, typename ValueType> struct HashTableAddResult
, m_containerModifications(container->modifications())
#endif
{
- ASSERT_UNUSED(container, container);
+ ALLOW_UNUSED_LOCAL(container);
Nico 2016/03/18 14:34:25 Is this needed? container is used (assigned to m_c
Nico 2016/03/22 02:56:21 (Did you see this?)
tkent 2016/03/22 03:04:21 It's used only if ENABLE(SECURITY_ASSERT). I remem
+ DCHECK(container);
}
ValueType* storedValue;
« no previous file with comments | « third_party/WebKit/Source/wtf/DEPS ('k') | third_party/WebKit/Source/wtf/RefCountedLeakCounter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698