[ios] Refactored dialogs suppression.

[ios] Refactored dialogs suppression.

1.) Added |suppressDialogs| property to CRWWebController, which should
    be used instead of |setPageDialogOpenPolicy|.
2.) Suppress all dialogs in native code instead of JavaScript (except
    navigation dialogs which can not be suppressed w/o JS override).
3.) Suppress HTTP Auth dialog if |suppressDialogs| is YES.

BUG=595463
TEST=window.open, window.prompt, window.confirm, window.alert,
           geolocation and http auth dialogs should be blocked for preload
           pages. All these dialogs should work normally for regular pages.

Committed: https://crrev.com/45bfe025690492eeafe4f1a689cab5c2bcb91b2a
Cr-Commit-Position: refs/heads/master@{#381759}

[Eugene But (OOO till 7-30), 2016-03-17 01:51:27]

eugenebut@chromium.org changed reviewers:
+ jyquinn@chromium.org

[Eugene But (OOO till 7-30), 2016-03-17 01:51:33]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 01:51:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806043004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806043004/20001

[commit-bot: I haz the power, 2016-03-17 02:36:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 02:36:26]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-03-17 02:43:45]

Description was changed from

==========
[ios] Refactored dialogs suppression.

1.) Added |suppressDialogs| property to CRWWebController, which should
    be used instead of |setPageDialogOpenPolicy|.
2.) Suppress all dialogs in native code instead of JavaScript (except
    navigation dialogs which can not be suppressed w/o JS override).
3.) Suppress HTTP Auth dialog if |suppressDialogs| is YES.

BUG=595463
==========

to

==========
[ios] Refactored dialogs suppression.

1.) Added |suppressDialogs| property to CRWWebController, which should
    be used instead of |setPageDialogOpenPolicy|.
2.) Suppress all dialogs in native code instead of JavaScript (except
    navigation dialogs which can not be suppressed w/o JS override).
3.) Suppress HTTP Auth dialog if |suppressDialogs| is YES.

BUG=595463
TEST=window.open, window.prompt, window.confirm, window.alert,
           geolocation and http auth dialogs should be blocked for preload
           pages. All these dialogs should work normally for regular pages.
==========

[Jackie Quinn, 2016-03-17 17:46:42]

lgtm, with a couple nits/questions.

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/js/re...
File ios/web/web_state/js/resources/dialog_overrides.js (right):

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/js/re...
ios/web/web_state/js/resources/dialog_overrides.js:27: // may suppress the
dialog and notify host about that.
Nit: probably could remove "about that"

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller+protected.h (left):

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller+protected.h:161: - (void)titleDidChange;
I assume that this method just no longer exists. I don't see it in
crw_web_controller.mm on trunk, just wanted to confirm that's why it's getting
deleted here.

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:943: -
(void)setSuppressDialogs:(BOOL)flag {
why "flag" versus something like "supressDialogs"?

[Eugene But (OOO till 7-30), 2016-03-17 17:53:21]

Thanks!

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/js/re...
File ios/web/web_state/js/resources/dialog_overrides.js (right):

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/js/re...
ios/web/web_state/js/resources/dialog_overrides.js:27: // may suppress the
dialog and notify host about that.
On 2016/03/17 17:46:41, Jackie Quinn wrote:
> Nit: probably could remove "about that"

Done.

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller+protected.h (left):

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller+protected.h:161: - (void)titleDidChange;
On 2016/03/17 17:46:41, Jackie Quinn wrote:
> I assume that this method just no longer exists. I don't see it in
> crw_web_controller.mm on trunk, just wanted to confirm that's why it's getting
> deleted here.
Oh, yes. It's no longer exists.

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/1806043004/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:943: -
(void)setSuppressDialogs:(BOOL)flag {
On 2016/03/17 17:46:41, Jackie Quinn wrote:
> why "flag" versus something like "supressDialogs"?
|flag| was shorter, but I guess suppressDialogs would be more consistent with
existing code. Done.

[Eugene But (OOO till 7-30), 2016-03-17 17:53:26]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-03-17 17:53:27]

The patchset sent to the CQ was uploaded after l-g-t-m from jyquinn@chromium.org
Link to the patchset: https://codereview.chromium.org/1806043004/#ps40001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2016-03-17 17:53:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806043004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806043004/40001

[commit-bot: I haz the power, 2016-03-17 18:44:56]

Description was changed from

==========
[ios] Refactored dialogs suppression.

1.) Added |suppressDialogs| property to CRWWebController, which should
    be used instead of |setPageDialogOpenPolicy|.
2.) Suppress all dialogs in native code instead of JavaScript (except
    navigation dialogs which can not be suppressed w/o JS override).
3.) Suppress HTTP Auth dialog if |suppressDialogs| is YES.

BUG=595463
TEST=window.open, window.prompt, window.confirm, window.alert,
           geolocation and http auth dialogs should be blocked for preload
           pages. All these dialogs should work normally for regular pages.
==========

to

==========
[ios] Refactored dialogs suppression.

1.) Added |suppressDialogs| property to CRWWebController, which should
    be used instead of |setPageDialogOpenPolicy|.
2.) Suppress all dialogs in native code instead of JavaScript (except
    navigation dialogs which can not be suppressed w/o JS override).
3.) Suppress HTTP Auth dialog if |suppressDialogs| is YES.

BUG=595463
TEST=window.open, window.prompt, window.confirm, window.alert,
           geolocation and http auth dialogs should be blocked for preload
           pages. All these dialogs should work normally for regular pages.
==========

[commit-bot: I haz the power, 2016-03-17 18:44:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-17 18:46:27]

Description was changed from

==========
[ios] Refactored dialogs suppression.

1.) Added |suppressDialogs| property to CRWWebController, which should
    be used instead of |setPageDialogOpenPolicy|.
2.) Suppress all dialogs in native code instead of JavaScript (except
    navigation dialogs which can not be suppressed w/o JS override).
3.) Suppress HTTP Auth dialog if |suppressDialogs| is YES.

BUG=595463
TEST=window.open, window.prompt, window.confirm, window.alert,
           geolocation and http auth dialogs should be blocked for preload
           pages. All these dialogs should work normally for regular pages.
==========

to

==========
[ios] Refactored dialogs suppression.

1.) Added |suppressDialogs| property to CRWWebController, which should
    be used instead of |setPageDialogOpenPolicy|.
2.) Suppress all dialogs in native code instead of JavaScript (except
    navigation dialogs which can not be suppressed w/o JS override).
3.) Suppress HTTP Auth dialog if |suppressDialogs| is YES.

BUG=595463
TEST=window.open, window.prompt, window.confirm, window.alert,
           geolocation and http auth dialogs should be blocked for preload
           pages. All these dialogs should work normally for regular pages.

Committed: https://crrev.com/45bfe025690492eeafe4f1a689cab5c2bcb91b2a
Cr-Commit-Position: refs/heads/master@{#381759}
==========

[commit-bot: I haz the power, 2016-03-17 18:46:28]

Patchset 3 (id:??) landed as
https://crrev.com/45bfe025690492eeafe4f1a689cab5c2bcb91b2a
Cr-Commit-Position: refs/heads/master@{#381759}