Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: ios/web/public/web_state/ui/crw_web_delegate.h

Issue 1806043004: [ios] Refactored dialogs suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/web_state/js/resources/dialog_overrides.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/web_state/ui/crw_web_delegate.h
diff --git a/ios/web/public/web_state/ui/crw_web_delegate.h b/ios/web/public/web_state/ui/crw_web_delegate.h
index 51173ab4ecdd2de192017904898b1e688027f109..343d367ee2e2a0db9e309d1452d2ec0ea642e00a 100644
--- a/ios/web/public/web_state/ui/crw_web_delegate.h
+++ b/ios/web/public/web_state/ui/crw_web_delegate.h
@@ -199,8 +199,9 @@ typedef void (^SSLErrorCallback)(BOOL);
- (void)webController:(CRWWebController*)webController
didBlockPopup:(const web::BlockedPopupInfo&)blockedPopupInfo;
-// Called when CRWWebController did suppress a dialog (only if kSuppressDialogs
-// policy is set via -[CRWWebController setPageDialogsOpenPolicy:] method).
+// Called when CRWWebController did suppress a dialog (JavaScript, HTTP
+// authentication or window.open).
+// NOTE: Called only if CRWWebController.suppressDialogs is set to YES.
- (void)webControllerDidSuppressDialog:(CRWWebController*)webController;
// Called to retrieve the height of any header that is overlaying on top of the
« no previous file with comments | « no previous file | ios/web/web_state/js/resources/dialog_overrides.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698