Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: ios/web/web_state/ui/crw_web_controller+protected.h

Issue 1806043004: [ios] Refactored dialogs suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/ui/crw_web_controller.mm ('k') | ios/web/web_state/ui/crw_web_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller+protected.h
diff --git a/ios/web/web_state/ui/crw_web_controller+protected.h b/ios/web/web_state/ui/crw_web_controller+protected.h
index bc773355c0b1bdb27765ad537515c5172603dd84..e3db6f3a25223133bcad381efb76045fd7db8545 100644
--- a/ios/web/web_state/ui/crw_web_controller+protected.h
+++ b/ios/web/web_state/ui/crw_web_controller+protected.h
@@ -153,13 +153,6 @@ struct NewWindowInfo {
// subclass, since the existing logic is somewhat UIWebView-guesswork-based.
- (void)resetLoadState;
-// Evaluates given JavaScript to suppress the dialogs. Subclasses should prefer
-// synchronous execution.
-- (void)setSuppressDialogsWithHelperScript:(NSString*)script;
-
-// Called when CRWWebController believes that web page title has been changed.
-- (void)titleDidChange;
-
// Returns selector to handle JavaScript message with command property
// |command|. Subclasses may override to handle class-specific messages.
- (SEL)selectorToHandleJavaScriptCommand:(const std::string&)command;
@@ -350,6 +343,10 @@ struct NewWindowInfo {
// non-document-changing URL change.
- (void)didFinishNavigation;
+// Called when a JavaScript dialog, HTTP authentication dialog or window.open
+// call has been suppressed.
+- (void)didSuppressDialog;
+
// Returns the referrer policy for the given referrer policy string (as reported
// from JS).
- (web::ReferrerPolicy)referrerPolicyFromString:(const std::string&)policy;
« no previous file with comments | « ios/web/web_state/ui/crw_web_controller.mm ('k') | ios/web/web_state/ui/crw_web_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698