ios/web/web_state/ui/crw_web_controller_unittest.mm - Issue 1806043004: [ios] Refactored dialogs suppression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller_unittest.mm

Issue 1806043004: [ios] Refactored dialogs suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller_unittest.mm

diff --git a/ios/web/web_state/ui/crw_web_controller_unittest.mm b/ios/web/web_state/ui/crw_web_controller_unittest.mm

index 94ae3f254270b477c4c81fd6a607f8bfd7d81dc8..31c33f73817eb401b38f6709bbcc9414fbbf0bec 100644

--- a/ios/web/web_state/ui/crw_web_controller_unittest.mm

+++ b/ios/web/web_state/ui/crw_web_controller_unittest.mm

@@ -550,7 +550,7 @@ TEST_F(CRWWebControllerPageDialogOpenPolicyTest, AllowAlert) {

TEST_F(CRWWebControllerPageDialogOpenPolicyTest, SuppressConfirm) {

[[web_delegate_mock() expect] webControllerDidSuppressDialog:webController_];

[webController_ setPageDialogOpenPolicy:web::DIALOG_POLICY_SUPPRESS];

- EXPECT_NSEQ(@"", EvaluateJavaScriptAsString(@"confirm('test')"));

+ EXPECT_NSEQ(@"false", EvaluateJavaScriptAsString(@"confirm('test')"));

};

// Tests that window.confirm dialog is shown for DIALOG_POLICY_ALLOW and