Convert the bot_update module to use properties

Convert the bot_update module to use properties

R=iannucci@chromium.org
BUG=591172
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299329

[martiniss, 2016-03-16 00:01:09]

Description was changed from

==========
Convert the bot_update module to use properties

R=iannucci@chromium.org
BUG=
==========

to

==========
Convert the bot_update module to use properties

R=iannucci@chromium.org
BUG=591172
==========

[martiniss, 2016-03-16 00:01:12]

PTAL

[iannucci, 2016-03-16 20:54:59]

lgtm % dict argument

https://codereview.chromium.org/1805113003/diff/1/recipe_modules/bot_update/_...
File recipe_modules/bot_update/__init__.py (right):

https://codereview.chromium.org/1805113003/diff/1/recipe_modules/bot_update/_...
recipe_modules/bot_update/__init__.py:30: 'deps_revision_overrides':
Property(default={}),
yes, it definitely will/could. I think there's a frozendict in some util lib
that you could use instead. I thought config specs made it in for Property?
maybe not.

[martiniss, 2016-03-16 21:10:13]

On 2016/03/16 at 20:54:59, iannucci wrote:
> lgtm % dict argument
> 
>
https://codereview.chromium.org/1805113003/diff/1/recipe_modules/bot_update/_...
> File recipe_modules/bot_update/__init__.py (right):
> 
>
https://codereview.chromium.org/1805113003/diff/1/recipe_modules/bot_update/_...
> recipe_modules/bot_update/__init__.py:30: 'deps_revision_overrides':
Property(default={}),
> yes, it definitely will/could. I think there's a frozendict in some util lib
that you could use instead. I thought config specs made it in for Property?
maybe not.
Fixed

Also, will need to land https://codereview.chromium.org/1788653004 to make this
roll into build.

[martiniss, 2016-03-16 21:10:18]

The CQ bit was checked by martiniss@chromium.org

[martiniss, 2016-03-16 21:10:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1805113003/#ps20001
(title: "Freeze the dict!")

[commit-bot: I haz the power, 2016-03-16 21:10:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805113003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805113003/20001

[commit-bot: I haz the power, 2016-03-16 21:13:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 21:13:31]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[martiniss, 2016-03-16 21:19:08]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-03-16 21:19:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805113003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805113003/20001

[commit-bot: I haz the power, 2016-03-16 21:23:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 21:23:02]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[martiniss, 2016-03-16 22:19:30]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-03-16 22:19:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805113003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805113003/20001

[commit-bot: I haz the power, 2016-03-16 22:21:54]

Description was changed from

==========
Convert the bot_update module to use properties

R=iannucci@chromium.org
BUG=591172
==========

to

==========
Convert the bot_update module to use properties

R=iannucci@chromium.org
BUG=591172

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299329
==========

[commit-bot: I haz the power, 2016-03-16 22:21:55]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299329