Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1788653004: Fix bot_update api rename. (Closed)

Created:
4 years, 9 months ago by martiniss
Modified:
4 years, 9 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Fix bot_update api rename. Also includes the roll. Depends on https://codereview.chromium.org/1741983002 BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299331

Patch Set 1 #

Patch Set 2 : v8 #

Patch Set 3 : Include the roll. #

Patch Set 4 : Long line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M infra/config/recipes.cfg View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/v8/api.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/flutter/engine.py View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/swarming/staging.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
martiniss
PTAL
4 years, 9 months ago (2016-03-16 22:33:15 UTC) #4
iannucci
lgtm
4 years, 9 months ago (2016-03-16 22:42:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1788653004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1788653004/40001
4 years, 9 months ago (2016-03-16 22:42:55 UTC) #7
martiniss
PTAL
4 years, 9 months ago (2016-03-16 22:48:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3131)
4 years, 9 months ago (2016-03-16 22:50:04 UTC) #11
Paweł Hajdan Jr.
LGTM
4 years, 9 months ago (2016-03-16 22:51:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1788653004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1788653004/40001
4 years, 9 months ago (2016-03-16 22:52:44 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3132)
4 years, 9 months ago (2016-03-16 23:00:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1788653004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1788653004/60001
4 years, 9 months ago (2016-03-16 23:06:16 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 23:10:34 UTC) #21
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299331

Powered by Google App Engine
This is Rietveld 408576698