Convert the bot_update module to use properties

recipe_modules/bot_update/__init__.py

 DEPS = [
   'gclient',
   'recipe_engine/json',
   'recipe_engine/path',
   'recipe_engine/platform',
   'recipe_engine/properties',
   'recipe_engine/python',
   'recipe_engine/raw_io',
   'rietveld',
   'recipe_engine/step',
   'tryserver',
 ]
+
+from recipe_engine.recipe_api import Property
+
+PROPERTIES = {
+  'mastername': Property(default=None),
+  'buildername': Property(default=None),
+  'slavename': Property(default=None),
+  'issue': Property(default=None),
+  'patchset': Property(default=None),
+  'patch_url': Property(default=None),
+  'repository': Property(default=None),
+  'event.patchSet.ref': Property(default=None, param_name="gerrit_ref"),
+  'rietveld': Property(default=None),
+  'revision': Property(default=None),
+  'parent_got_revision': Property(default=None),
+  # TODO: convert to not using direct python argument, since this could probably
+  # cause unforseen bugs because of mutation
+  'deps_revision_overrides': Property(default={}),

[iannucci, 2016/03/16 20:54:59]

yes, it definitely will/could. I think there's a frozendict in some util lib
that you could use instead. I thought config specs made it in for Property?
maybe not.

+  'fail_patch': Property(default=None, kind=str),
+}