recipe_modules/bot_update/__init__.py - Issue 1805113003: Convert the bot_update module to use properties

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: recipe_modules/bot_update/init.py

Issue 1805113003: Convert the bot_update module to use properties (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Freeze the dict! Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 DEPS = [	1 DEPS = [

2 'gclient',	2 'gclient',

3 'recipe_engine/json',	3 'recipe_engine/json',

4 'recipe_engine/path',	4 'recipe_engine/path',

5 'recipe_engine/platform',	5 'recipe_engine/platform',

6 'recipe_engine/properties',	6 'recipe_engine/properties',

7 'recipe_engine/python',	7 'recipe_engine/python',

8 'recipe_engine/raw_io',	8 'recipe_engine/raw_io',

9 'rietveld',	9 'rietveld',

10 'recipe_engine/step',	10 'recipe_engine/step',

11 'tryserver',	11 'tryserver',

12 ]	12 ]

	13

	14 from recipe_engine.recipe_api import Property

	15 from recipe_engine.types import freeze

	16

	17 PROPERTIES = {

	18 'mastername': Property(default=None),

	19 'buildername': Property(default=None),

	20 'slavename': Property(default=None),

	21 'issue': Property(default=None),

	22 'patchset': Property(default=None),

	23 'patch_url': Property(default=None),

	24 'repository': Property(default=None),

	25 'event.patchSet.ref': Property(default=None, param_name="gerrit_ref"),

	26 'rietveld': Property(default=None),

	27 'revision': Property(default=None),

	28 'parent_got_revision': Property(default=None),

	29 'deps_revision_overrides': Property(default=freeze({})),

	30 'fail_patch': Property(default=None, kind=str),

	31 }

OLD	NEW

« no previous file with comments | « no previous file | recipe_modules/bot_update/api.py » ('j') | no next file with comments »

Side by Side Diff: recipe_modules/bot_update/__init__.py

Side by Side Diff: recipe_modules/bot_update/init.py