Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1804293002: Discourage use of android.app.AlertDialog and StringBuffer. (Closed)

Created:
4 years, 9 months ago by newt (away)
Modified:
4 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, kalyank, sadrul, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, PEConn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Discourage use of android.app.AlertDialog and StringBuffer. android.support.v7.app.AlertDialog and StringBuilder should be used instead. BUG=4562 Committed: https://crrev.com/6e35db99271ad9312089a3bc0d3474acff9ceef8 Cr-Commit-Position: refs/heads/master@{#381350}

Patch Set 1 #

Patch Set 2 : explain thread-safety issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java View 2 chunks +2 lines, -1 line 0 comments Download
M tools/android/checkstyle/chromium-style-5.0.xml View 1 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
newt (away)
PTAL
4 years, 9 months ago (2016-03-15 22:33:31 UTC) #2
Ted C
lgtm
4 years, 9 months ago (2016-03-15 22:40:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804293002/20001
4 years, 9 months ago (2016-03-15 22:43:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-15 23:35:25 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 23:37:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e35db99271ad9312089a3bc0d3474acff9ceef8
Cr-Commit-Position: refs/heads/master@{#381350}

Powered by Google App Engine
This is Rietveld 408576698