chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java - Issue 1804293002: Discourage use of android.app.AlertDialog and StringBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java

Issue 1804293002: Discourage use of android.app.AlertDialog and StringBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: explain thread-safety issue Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java ('k') | tools/android/checkstyle/chromium-style-5.0.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java

index 861235f6268c52e64140d15678d50754ead5bf52..40558d037d2a45ca6164d2d27732797bb9f4bd84 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java

@@ -25,6 +25,7 @@ import java.util.concurrent.atomic.AtomicInteger;

public class LogcatExtractionCallableTest extends CrashTestCase {

private File mCrashDir;

+ @Override

protected void setUp() throws Exception {

super.setUp();

mCrashDir = new CrashFileManager(mCacheDir).getCrashDirectory();

@@ -81,7 +82,7 @@ public class LogcatExtractionCallableTest extends CrashTestCase {

File logfile = new File(mCrashDir, fileName);

assertTrue("Logfile does not exist!", logfile.exists());

BufferedReader input = new BufferedReader(new FileReader(logfile));

- StringBuffer sb = new StringBuffer();

+ StringBuilder sb = new StringBuilder();

String line = null;

while ((line = input.readLine()) != null) {

sb.append(line);