chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java - Issue 1804293002: Discourage use of android.app.AlertDialog and StringBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java

Issue 1804293002: Discourage use of android.app.AlertDialog and StringBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: explain thread-safety issue Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java

index 607772cd85cc88654920c1fe5ca41e89f0daace5..281708669fbd1ac10d7091decfcc20c0b49207d7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java

@@ -357,7 +357,7 @@ public class LogcatExtractionCallable implements Callable<Boolean> {

@VisibleForTesting

protected static String elideUrl(String original) {

- StringBuffer buffer = new StringBuffer(original);

+ StringBuilder buffer = new StringBuilder(original);

Matcher matcher = WEB_URL.matcher(buffer);

int start = 0;

while (matcher.find(start)) {

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java » ('j') | no next file with comments »