Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: tools/android/checkstyle/chromium-style-5.0.xml

Issue 1804293002: Discourage use of android.app.AlertDialog and StringBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: explain thread-safety issue Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd"> 2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd">
3 3
4 <!-- 4 <!--
5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle 5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle
6 --> 6 -->
7 <module name="Checker"> 7 <module name="Checker">
8 <property name="severity" value="warning"/> 8 <property name="severity" value="warning"/>
9 <property name="charset" value="UTF-8"/> 9 <property name="charset" value="UTF-8"/>
10 <module name="TreeWalker"> 10 <module name="TreeWalker">
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 <property name="reliefPattern" value=".*"/> 117 <property name="reliefPattern" value=".*"/>
118 </module> 118 </module>
119 <module name="ModifierOrder"> 119 <module name="ModifierOrder">
120 <property name="severity" value="error"/> 120 <property name="severity" value="error"/>
121 </module> 121 </module>
122 <module name="WhitespaceAround"> 122 <module name="WhitespaceAround">
123 <property name="severity" value="error"/> 123 <property name="severity" value="error"/>
124 <property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAND , LE, LITERAL_ASSERT, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE, LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN, LITERAL_SYNCHRONIZED, LITERAL_TRY, LITE RAL_WHILE, LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ ASSIGN, QUESTION, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN, TYPE_E XTENSION_AND" /> 124 <property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAND , LE, LITERAL_ASSERT, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE, LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN, LITERAL_SYNCHRONIZED, LITERAL_TRY, LITE RAL_WHILE, LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ ASSIGN, QUESTION, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN, TYPE_E XTENSION_AND" />
125 <property name="allowEmptyConstructors" value="true"/> 125 <property name="allowEmptyConstructors" value="true"/>
126 <property name="allowEmptyMethods" value="true"/> 126 <property name="allowEmptyMethods" value="true"/>
127 </module> 127 </module>
128 <module name="WhitespaceAfter"> 128 <module name="WhitespaceAfter">
129 <property name="severity" value="error"/> 129 <property name="severity" value="error"/>
130 <property name="tokens" value="COMMA, SEMI, TYPECAST"/> 130 <property name="tokens" value="COMMA, SEMI, TYPECAST"/>
131 </module> 131 </module>
132 <module name="NoWhitespaceAfter"> 132 <module name="NoWhitespaceAfter">
133 <property name="severity" value="error"/> 133 <property name="severity" value="error"/>
134 <property name="tokens" value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNA RY_PLUS"/> 134 <property name="tokens" value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNA RY_PLUS"/>
135 </module> 135 </module>
136 <module name="NoWhitespaceBefore"> 136 <module name="NoWhitespaceBefore">
137 <property name="severity" value="error"/> 137 <property name="severity" value="error"/>
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 <module name="SeparatorWrap"> 189 <module name="SeparatorWrap">
190 <property name="severity" value="error"/> 190 <property name="severity" value="error"/>
191 <property name="tokens" value="DOT"/> 191 <property name="tokens" value="DOT"/>
192 <property name="option" value="nl"/> 192 <property name="option" value="nl"/>
193 </module> 193 </module>
194 <module name="SeparatorWrap"> 194 <module name="SeparatorWrap">
195 <property name="severity" value="error"/> 195 <property name="severity" value="error"/>
196 <property name="tokens" value="COMMA"/> 196 <property name="tokens" value="COMMA"/>
197 <property name="option" value="EOL"/> 197 <property name="option" value="EOL"/>
198 </module> 198 </module>
199 <module name="RegexpSinglelineJava">
200 <property name="severity" value="error"/>
201 <property name="format" value="StringBuffer"/>
202 <property name="ignoreComments" value="true"/>
203 <property name="message" value="Avoid StringBuffer; use StringBuilder inst ead, which is faster (it's not thread-safe, but this is almost never needed)"/>
204 </module>
205 <module name="RegexpSinglelineJava">
206 <property name="severity" value="warning"/>
207 <property name="format" value="android\.app\.AlertDialog"/>
208 <property name="ignoreComments" value="true"/>
209 <property name="message" value="Avoid android.app.AlertDialog; if possible , use android.support.v7.app.AlertDialog instead, which has a Material look on a ll devices. (Some parts of the codebase can’t depend on the support library, in which case android.app.AlertDialog is the only option)"/>
210 </module>
199 </module> 211 </module>
212
213 <!-- Non-TreeWalker modules -->
200 <module name="FileTabCharacter"> 214 <module name="FileTabCharacter">
201 <property name="severity" value="error"/> 215 <property name="severity" value="error"/>
202 </module> 216 </module>
203 <module name="RegexpSingleline"> 217 <module name="RegexpSingleline">
204 <property name="severity" value="error"/> 218 <property name="severity" value="error"/>
205 <property name="format" value="[ \t]+$"/> 219 <property name="format" value="[ \t]+$"/>
206 <property name="message" value="Trailing whitespace"/> 220 <property name="message" value="Trailing whitespace"/>
207 </module> 221 </module>
208 <module name="RegexpHeader"> 222 <module name="RegexpHeader">
209 <property name="severity" value="error"/> 223 <property name="severity" value="error"/>
210 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/> 224 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/>
211 </module> 225 </module>
212 </module> 226 </module>
OLDNEW
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698