Move all flags to CompilerOptions (first step to stop passing the compiler to

Move all flags to CompilerOptions (first step to stop passing the compiler to
just get the options in the future).

BUG=
R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/4f3a7cb86e04bb1d4d06902924d9c7275a3b6527

[Siggi Cherem (dart-lang), 2016-03-16 04:23:36]

Patchset #2 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2016-03-16 04:23:53]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2016-03-16 04:36:08]

Patchset #1 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2016-03-16 04:40:53]

sigmund@google.com changed reviewers:
+ johnniwinther@google.com

[Siggi Cherem (dart-lang), 2016-03-16 04:40:54]

Note: this CL is built on top of 2 other CLs that I haven't submitted yet. One
that deletes source-mirrors (which I reverted today), another that deletes a
subset of site/try (needed before I can delete mirrors) so that I don't have to
change any entrypoints there.

I haven't found how to test if pub-build continues to work with the changes, I
will follow up on that tomorrow, but overall this is ready for a look.

[Johnni Winther, 2016-03-16 09:37:27]

lgtm

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
File pkg/compiler/lib/compiler_new.dart (right):

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:106: /// if not null then [packageConfig]
should be null.
'if' -> 'If'

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:111: /// if not null then [packageRoot]
should be null.
Ditto.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:137: // main function is retained, which is
the opposite of what this does.
When used together with analyzeOnly it doesn't even tree-shake...

What we want (effectively) are the 4 modes in AnalysisMode in
tests/compiler/dart2js/analyze_helper.dart

... and renaming is needed!

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:202: /// Generate output even when there are
compile-time errors.
'Generate' -> 'Whether to generate'

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:209: /// Incremental compilation is allows
calling `Compiler.run` more than once.
Remove 'is '. Add '(experimental)'.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:215: /// Location of the plaform
configuration file.
'plaform' -> 'platform'

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:239: /// Use the new CPS based backend end. 
This flag works for both the Dart and
Remove mentioning of backends.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:286: bool disableInlining: false}) {
Add '--disable-inlining' to [Flags] and parse it here. We still filter options
from the commandline in dart2js.dart so it is not exposed to normal users.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart (right):

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart:1431: assert(element
is LibraryElement || compiler.options.hasIncrementalSupport);
Long line.

[Siggi Cherem (dart-lang), 2016-03-17 22:56:52]

Patchset #2 (id:80001) has been deleted

[Siggi Cherem (dart-lang), 2016-03-17 22:57:14]

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
File pkg/compiler/lib/compiler_new.dart (right):

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:106: /// if not null then [packageConfig]
should be null.
On 2016/03/16 09:37:27, Johnni Winther wrote:
> 'if' -> 'If'

Done.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:111: /// if not null then [packageRoot]
should be null.
On 2016/03/16 09:37:27, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:137: // main function is retained, which is
the opposite of what this does.
On 2016/03/16 09:37:27, Johnni Winther wrote:
> When used together with analyzeOnly it doesn't even tree-shake...
> 
> What we want (effectively) are the 4 modes in AnalysisMode in
> tests/compiler/dart2js/analyze_helper.dart
> 
> ... and renaming is needed!

Acknowledged.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:202: /// Generate output even when there are
compile-time errors.
On 2016/03/16 09:37:27, Johnni Winther wrote:
> 'Generate' -> 'Whether to generate'

Done.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:209: /// Incremental compilation is allows
calling `Compiler.run` more than once.
On 2016/03/16 09:37:27, Johnni Winther wrote:
> Remove 'is '. Add '(experimental)'.

Done.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:215: /// Location of the plaform
configuration file.
On 2016/03/16 09:37:27, Johnni Winther wrote:
> 'plaform' -> 'platform'

Done.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:239: /// Use the new CPS based backend end. 
This flag works for both the Dart and
On 2016/03/16 09:37:27, Johnni Winther wrote:
> Remove mentioning of backends.

Done.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:286: bool disableInlining: false}) {
On 2016/03/16 09:37:27, Johnni Winther wrote:
> Add '--disable-inlining' to [Flags] and parse it here. We still filter options
> from the commandline in dart2js.dart so it is not exposed to normal users.

Done.

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart (right):

https://codereview.chromium.org/1803303002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart:1431: assert(element
is LibraryElement || compiler.options.hasIncrementalSupport);
On 2016/03/16 09:37:27, Johnni Winther wrote:
> Long line.

Done.

[Siggi Cherem (dart-lang), 2016-03-17 23:42:07]

Description was changed from

==========
Move all flags to CompilerOptions (first step to stop passing the compiler to
just get the options in the future).

BUG=
==========

to

==========
Move all flags to CompilerOptions (first step to stop passing the compiler to
just get the options in the future).

BUG=
R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4f3a7cb86e04bb1d4d06902924d9c7275a3b6527
==========

[Siggi Cherem (dart-lang), 2016-03-17 23:42:08]

Committed patchset #2 (id:100001) manually as
4f3a7cb86e04bb1d4d06902924d9c7275a3b6527 (presubmit successful).

[Siggi Cherem (dart-lang), 2016-03-17 23:43:07]

FYI I fixed one more place in mirrors/analyze to unblock this (I was able to
land this before deleting source-mirrors)