Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/dart2js_incremental/lib/caching_compiler.dart

Issue 1803303002: Move all flags to CompilerOptions (first step to stop passing the compiler to (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/world.dart ('k') | pkg/dart2js_incremental/lib/dart2js_incremental.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dart2js_incremental/lib/caching_compiler.dart
diff --git a/pkg/dart2js_incremental/lib/caching_compiler.dart b/pkg/dart2js_incremental/lib/caching_compiler.dart
index 4185df1c46b8be92bb1e72bc2a37a9d08b97cb64..f7f8f1004f69989bb05cf5484906e6d2f14a1834 100644
--- a/pkg/dart2js_incremental/lib/caching_compiler.dart
+++ b/pkg/dart2js_incremental/lib/caching_compiler.dart
@@ -36,11 +36,11 @@ Future<CompilerImpl> reuseCompiler(
CompilerImpl compiler = cachedCompiler;
if (compiler == null ||
compiler.libraryRoot != libraryRoot ||
- !compiler.hasIncrementalSupport ||
+ !compiler.options.hasIncrementalSupport ||
compiler.hasCrashed ||
compiler.enqueuer.resolution.hasEnqueuedReflectiveElements ||
compiler.deferredLoadTask.isProgramSplit) {
- if (compiler != null && compiler.hasIncrementalSupport) {
+ if (compiler != null && compiler.options.hasIncrementalSupport) {
print('***FLUSH***');
if (compiler.hasCrashed) {
print('Unable to reuse compiler due to crash.');
@@ -57,12 +57,11 @@ Future<CompilerImpl> reuseCompiler(
inputProvider,
outputProvider,
diagnosticHandler,
- libraryRoot,
- packageRoot,
- options,
- environment,
- null,
- null);
+ new CompilerOptions.parse(
+ libraryRoot: libraryRoot,
+ packageRoot: packageRoot,
+ options: options,
+ environment: environment));
JavaScriptBackend backend = compiler.backend;
full.Emitter emitter = backend.emitter.emitter;
« no previous file with comments | « pkg/compiler/lib/src/world.dart ('k') | pkg/dart2js_incremental/lib/dart2js_incremental.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698