pkg/compiler/lib/src/js_emitter/program_builder/collector.dart - Issue 1803303002: Move all flags to CompilerOptions (first step to stop passing the compiler to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

Issue 1803303002: Move all flags to CompilerOptions (first step to stop passing the compiler to (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/metadata_collector.dart ('k') | pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

index 268d67150f357bc270cc85d6c711aca02428e343..2f5d257f1d28a56f149b3cba556419635390d1e4 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

@@ -148,7 +148,8 @@ class Collector {

JavaScriptConstantCompiler handler = backend.constants;

List<ConstantValue> constants = handler.getConstantsForEmission(

- compiler.hasIncrementalSupport ? null : emitter.compareConstants);

+ compiler.options.hasIncrementalSupport ? null

+ : emitter.compareConstants);

for (ConstantValue constant in constants) {

if (emitter.isConstantInlinedOrAlreadyEmitted(constant)) continue;

@@ -314,4 +315,4 @@ class Collector {

computeNeededStaticNonFinalFields();

computeNeededLibraries();

}