pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart - Issue 1803303002: Move all flags to CompilerOptions (first step to stop passing the compiler to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart

Issue 1803303002: Move all flags to CompilerOptions (first step to stop passing the compiler to (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart ('k') | pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart b/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart

index a0b9b48febbbf092a5110f6b4422ed9c347de940..d2dd9fd125cef5ae0ee6b746f6b3c13d42362f03 100644

--- a/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart

@@ -193,7 +193,9 @@ class ModelEmitter {

String buildGeneratedBy(compiler) {

var suffix = '';

- if (compiler.hasBuildId) suffix = ' version: ${compiler.buildId}';

+ if (compiler.options.hasBuildId) {

+ suffix = ' version: ${compiler.options.buildId}';

+ }

return '// Generated by dart2js, the Dart to JavaScript compiler$suffix.\n';

}