Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Issue 1803113002: PPC: [wasm] Int64Lowering of Int64Add. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [wasm] Int64Lowering of Int64Add. Port 1b230799364b7a6fbff3b0ffaee38bc06e19504b Original commit message: Int64Add is lowered to a new turbofan operator, Int32AddPair. The new operator takes 4 inputs an generates 2 outputs. The inputs are the low word of the left input, high word of the left input, the low word of the right input, and high word of the right input. The ouputs are the low and high word of the result of the addition. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/0548cf49d59cb7f59e1b0b4c2da79ca9a739abfb Cr-Commit-Position: refs/heads/master@{#34797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -7 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-scheduler-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M src/ppc/assembler-ppc.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/disasm-ppc.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-15 18:01:13 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803113002/1
4 years, 9 months ago (2016-03-15 18:01:29 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 18:22:59 UTC) #5
john.yan
lgtm
4 years, 9 months ago (2016-03-15 19:26:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803113002/1
4 years, 9 months ago (2016-03-15 20:14:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 20:15:52 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 20:16:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0548cf49d59cb7f59e1b0b4c2da79ca9a739abfb
Cr-Commit-Position: refs/heads/master@{#34797}

Powered by Google App Engine
This is Rietveld 408576698