Issue 180016: Extension API Renaming/Consistency changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180016: Extension API Renaming/Consistency changes (Closed)

Created:
11 years, 3 months ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Extension API Renaming/Consistency changes BUG=20288 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24770

Patch Set 3 : fix more samples, touch grds #

Patch Set 4 : fix line endings #

Patch Set 5 : render docs #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+441 lines, -286 lines)			Patch
M	chrome/browser/extensions/extension_bookmarks_module.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module_constants.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module_constants.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_browser_event_router.cc	View		2 chunks	+17 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_browsertests_misc.cc	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_messages_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.cc	View		11 chunks	+51 lines, -45 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module_constants.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module_constants.cc	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_toolstrip_api.cc	View		4 chunks	+28 lines, -21 lines	0 comments	Download
M	chrome/browser/extensions/extension_uitest.cc	View		2 chunks	+19 lines, -17 lines	0 comments	Download
M	chrome/common/common_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View		8 chunks	+52 lines, -14 lines	0 comments	Download
M	chrome/common/extensions/docs/api_other.html	View		1 chunk	+1 line, -34 lines	0 comments	Download
M	chrome/common/extensions/docs/content_scripts.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/getstarted.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/overview.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/packaging.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/pageActions.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/tabs.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/extensions/extension_api_client_unittest.cc	View		2 chunks	+35 lines, -21 lines	0 comments	Download
M	chrome/renderer/renderer_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/resources/extension_process_bindings.js	View		8 chunks	+18 lines, -14 lines	0 comments	Download
M	chrome/renderer/resources/renderer_extension_bindings.js	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/test/data/extensions/browsertest/last_error/toolstrip.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/toolstrip.html	View		1 chunk	+80 lines, -65 lines	0 comments	Download
M	chrome/test/data/extensions/samples/bookmarks/bookmark_api.html	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/samples/bookmarks/bookmark_view.html	View		3 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/test/data/extensions/samples/bookmarks/manifest.json	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	chrome/test/data/extensions/samples/mole/manifest.json	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/samples/mole/mole.html	View	2 3	1 chunk	+67 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/samples/subscribe_page_action/background.html	View	2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/samples/tabs/tabs_api.html	View	2 3	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/test/data/extensions/uitest/event_sink/test.html	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

lgtm, please wait till tomorrow to check in. http://codereview.chromium.org/180016/diff/1/16 File chrome/renderer/resources/extension_process_bindings.js (right): http://codereview.chromium.org/180016/diff/1/16#newcode259 Line 259: ...

11 years, 3 months ago (2009-08-28 02:25:09 UTC) #2

rafaelw

11 years, 3 months ago (2009-08-28 03:06:13 UTC) #3

http://codereview.chromium.org/180016/diff/1/16
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/180016/diff/1/16#newcode259
Line 259: name = connectInfo.name || name;
On 2009/08/28 02:25:09, Aaron Boodman wrote:
> name |= conectInfo.name

I think that's bitwize OR.