Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5058)

Unified Diff: chrome/browser/extensions/extension_uitest.cc

Issue 180016: Extension API Renaming/Consistency changes (Closed)
Patch Set: render docs Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_toolstrip_api.cc ('k') | chrome/common/common_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_uitest.cc
diff --git a/chrome/browser/extensions/extension_uitest.cc b/chrome/browser/extensions/extension_uitest.cc
index 0f189eaac00bf5702e08a87d4dc526d0c6f343d8..0d48dcd70ed9642d617439ba0a66ab9738a34a87 100644
--- a/chrome/browser/extensions/extension_uitest.cc
+++ b/chrome/browser/extensions/extension_uitest.cc
@@ -248,7 +248,8 @@ class RoundtripAutomationProxy : public MultiMessageAutomationProxy {
std::string tab_json;
JSONWriter::Write(&tab_dict, false, &tab_json);
- EXPECT_TRUE(response_dict.SetString(keys::kAutomationResponseKey, tab_json));
+ EXPECT_TRUE(response_dict.SetString(keys::kAutomationResponseKey,
+ tab_json));
std::string response_json;
JSONWriter::Write(&response_dict, false, &response_json);
@@ -335,40 +336,41 @@ class BrowserEventAutomationProxy : public MultiMessageAutomationProxy {
const char* BrowserEventAutomationProxy::events_[] = {
// Window events.
- "[\"windows.onCreated\", \"[42]\"]",
-
+ "[\"windows.onCreated\", \"[{'id':42}]\"]",
+
"[\"windows.onRemoved\", \"[42]\"]",
-
+
"[\"windows.onFocusChanged\", \"[42]\"]",
-
+
// Tab events.
"[\"tabs.onCreated\", \"[{'id\':42,'index':1,'windowId':1,"
"'selected':true,'url':'http://www.google.com'}]\"]",
-
+
"[\"tabs.onUpdated\", \"[42, {'status': 'complete',"
"'url':'http://www.google.com'}]\"]",
-
+
"[\"tabs.onMoved\", \"[42, {'windowId':1,'fromIndex':1,'toIndex':2}]\"]",
-
+
"[\"tabs.onSelectionChanged\", \"[42, {'windowId':1}]\"]",
-
+
"[\"tabs.onAttached\", \"[42, {'newWindowId':1,'newPosition':1}]\"]",
-
+
"[\"tabs.onDetached\", \"[43, {'oldWindowId':1,'oldPosition':1}]\"]",
-
+
"[\"tabs.onRemoved\", \"[43]\"]",
// Bookmark events.
- "[\"bookmarks.onAdded\", \"['42', {'id':'42','title':'foo',}]\"]",
-
+ "[\"bookmarks.onCreated\", \"['42', {'id':'42','title':'foo',}]\"]",
+
"[\"bookmarks.onRemoved\", \"['42', {'parentId':'2','index':1}]\"]",
-
+
"[\"bookmarks.onChanged\", \"['42', {'title':'foo'}]\"]",
-
+
"[\"bookmarks.onMoved\", \"['42', {'parentId':'2','index':1,"
"'oldParentId':'3','oldIndex':2}]\"]",
-
- "[\"bookmarks.onChildrenReordered\", \"['32', ['1', '2', '3']]\"]"
+
+ "[\"bookmarks.onChildrenReordered\", \"['32', "
+ "{'childIds':['1', '2', '3']}]\"]"
};
void BrowserEventAutomationProxy::HandleMessageFromChrome() {
« no previous file with comments | « chrome/browser/extensions/extension_toolstrip_api.cc ('k') | chrome/common/common_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698