Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/data/extensions/samples/bookmarks/bookmark_api.html

Issue 180016: Extension API Renaming/Consistency changes (Closed)
Patch Set: render docs Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/toolstrip.html ('k') | chrome/test/data/extensions/samples/bookmarks/bookmark_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/samples/bookmarks/bookmark_api.html
diff --git a/chrome/test/data/extensions/samples/bookmarks/bookmark_api.html b/chrome/test/data/extensions/samples/bookmarks/bookmark_api.html
index 886b43f338658f17b47ea743cc99efe055d03a46..7421ad6a3000cd0a20bb52159585fb4386573084 100644
--- a/chrome/test/data/extensions/samples/bookmarks/bookmark_api.html
+++ b/chrome/test/data/extensions/samples/bookmarks/bookmark_api.html
@@ -34,7 +34,7 @@ var testMoveBookmarks2 = function(event) {
return;
}
console.log("testMoveBookmarks2");
- chrome.bookmarks.getChildren(0, function(root_children) {
+ chrome.bookmarks.getChildren('0', function(root_children) {
var bookmark_bar = root_children[0]; // bookmarks bar is always first
chrome.bookmarks.getChildren(bookmark_bar.id, function(bar_children) {
var folder_search = [];
@@ -74,7 +74,7 @@ var testMoveBookmarks2 = function(event) {
};
var dumpBookmarks = function(event) {
- window.open("bookmark_view.html");
+ chrome.tabs.create({url:"bookmark_view.html"});
};
</script>
<body>
« no previous file with comments | « chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/toolstrip.html ('k') | chrome/test/data/extensions/samples/bookmarks/bookmark_view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698