chrome/test/data/extensions/browsertest/last_error/toolstrip.html - Issue 180016: Extension API Renaming/Consistency changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/browsertest/last_error/toolstrip.html

Issue 180016: Extension API Renaming/Consistency changes (Closed)

Patch Set: render docs Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/renderer/resources/renderer_extension_bindings.js ('k') | chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 function fail() {	4 function fail() {

5 window.domAutomationController.send(false);	5 window.domAutomationController.send(false);

6 throw "Failed!";	6 throw "Failed!";

7 }	7 }

8	8

9 function succeed() {	9 function succeed() {

10 window.domAutomationController.send(true);	10 window.domAutomationController.send(true);

11 }	11 }

12	12

13 function testLastError() {	13 function testLastError() {

14 // Make sure lastError is not yet set	14 // Make sure lastError is not yet set

15 if (chrome.tabs.lastError)	15 if (chrome.tabs.lastError)

16 fail();	16 fail();

17	17

18 var maxTabId = 0;	18 var maxTabId = 0;

19	19

20 // Find the highest tab id	20 // Find the highest tab id

21 chrome.windows.getAll(true, function(windows) {	21 chrome.windows.getAll({populate:true}, function(windows) {

22 // Make sure lastError is still not set. (this call have should succeeded).	22 // Make sure lastError is still not set. (this call have should succeeded).

23 if (chrome.tabs.lastError)	23 if (chrome.tabs.lastError)

24 fail();	24 fail();

25	25

26 for (var i = 0; i < windows.length; i++) {	26 for (var i = 0; i < windows.length; i++) {

27 var win = windows[i];	27 var win = windows[i];

28 for (var j = 0; j < win.tabs.length; j++) {	28 for (var j = 0; j < win.tabs.length; j++) {

29 var tab = win.tabs[j];	29 var tab = win.tabs[j];

30 if (tab.id > maxTabId)	30 if (tab.id > maxTabId)

31 maxTabId = tab.id;	31 maxTabId = tab.id;

(...skipping 20 matching lines...) Expand all Loading...
52	52

53 succeed();	53 succeed();

54 }	54 }

55 </script>	55 </script>

56 </head>	56 </head>

57 <body>	57 <body>

58 <div onclick="testLastError();"> Last Error Test </div>	58 <div onclick="testLastError();"> Last Error Test </div>

59 </body>	59 </body>

60 </html>	60 </html>

61	61

OLD	NEW