Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1800083003: Add iossim as data_deps for iOS application bundles. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@iossim.gn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add iossim as data_deps for iOS application bundles. When targetting simulator, builds iossim as a data_deps for all iOS application bundle as it is required to run the bundle on simulator from the command-line. BUG=594519 Committed: https://crrev.com/8d689ca9b2db1f4a5629c50e5fc2f97e47795197 Cr-Commit-Position: refs/heads/master@{#381696}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use ${host_toolchain} instead of //build/toolchain/mac:clang_x64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M build/config/ios/rules.gni View 1 2 chunks +7 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
sdefresne
Please take a look.
4 years, 9 months ago (2016-03-15 14:06:41 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/1800083003/diff/1/build/config/ios/rules.gni File build/config/ios/rules.gni (right): https://codereview.chromium.org/1800083003/diff/1/build/config/ios/rules.gni#newcode152 build/config/ios/rules.gni:152: data_deps += [ "//testing/iossim(//build/toolchain/mac:clang_x64)" ] nit: this should ...
4 years, 9 months ago (2016-03-16 01:22:07 UTC) #3
sdefresne
Thank you for the review. https://codereview.chromium.org/1800083003/diff/1/build/config/ios/rules.gni File build/config/ios/rules.gni (right): https://codereview.chromium.org/1800083003/diff/1/build/config/ios/rules.gni#newcode152 build/config/ios/rules.gni:152: data_deps += [ "//testing/iossim(//build/toolchain/mac:clang_x64)" ...
4 years, 9 months ago (2016-03-17 12:11:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800083003/20001
4 years, 9 months ago (2016-03-17 12:11:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 13:05:10 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 13:06:25 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d689ca9b2db1f4a5629c50e5fc2f97e47795197
Cr-Commit-Position: refs/heads/master@{#381696}

Powered by Google App Engine
This is Rietveld 408576698