Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: build/config/ios/rules.gni

Issue 1800083003: Add iossim as data_deps for iOS application bundles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iossim.gn
Patch Set: Use ${host_toolchain} instead of //build/toolchain/mac:clang_x64 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ios/ios_sdk.gni") 5 import("//build/config/ios/ios_sdk.gni")
6 6
7 # TODO(crbug.com/297668): refactor this template to extract common behaviour 7 # TODO(crbug.com/297668): refactor this template to extract common behaviour
8 # between OS X and iOS bundle generation, then create a generic "app" template 8 # between OS X and iOS bundle generation, then create a generic "app" template
9 # that forward to "executable" on all platform except iOS/OS X. 9 # that forward to "executable" on all platform except iOS/OS X.
10 10
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 ]) 140 ])
141 141
142 if (!defined(deps)) { 142 if (!defined(deps)) {
143 deps = [] 143 deps = []
144 } 144 }
145 deps += [ 145 deps += [
146 ":$_bundle_data_executable", 146 ":$_bundle_data_executable",
147 ":$_bundle_data_info_plist", 147 ":$_bundle_data_info_plist",
148 ] 148 ]
149 149
150 if (use_ios_simulator) {
151 if (!defined(data_deps)) {
152 data_deps = []
153 }
154 data_deps += [ "//testing/iossim(${host_toolchain})" ]
155 }
156
150 bundle_root_dir = "$root_out_dir/$_app_name.app" 157 bundle_root_dir = "$root_out_dir/$_app_name.app"
151 bundle_resources_dir = bundle_root_dir 158 bundle_resources_dir = bundle_root_dir
152 bundle_executable_dir = bundle_root_dir 159 bundle_executable_dir = bundle_root_dir
153 bundle_plugins_dir = "$bundle_root_dir/Plugins" 160 bundle_plugins_dir = "$bundle_root_dir/Plugins"
154 } 161 }
155 162
156 # TODO(crbug.com/297668): 163 # TODO(crbug.com/297668):
157 # - add support for codesigning, 164 # - add support for codesigning,
158 # - find a way to make "ninja -C out/Default base_unittests.app" work as 165 # - find a way to make "ninja -C out/Default base_unittests.app" work as
159 # an alias to "ninja -C out/Default base_unittests" (for convenience 166 # an alias to "ninja -C out/Default base_unittests" (for convenience
160 # and compatibility with gyp), 167 # and compatibility with gyp),
161 # - implement //testing/iossim(//build/toolchain/mac:clang_x64) and then
162 # add a depency to that target.
163 } 168 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698