Add testing/iossim/BUILD.gn to build iossim as host for iOS build.

Add testing/iossim/BUILD.gn to build iossim as host for iOS build.

Remove some dead const variables flagged as such by clang (instead
of deactivating the compiler warning as the change was simple).

TBR=rohitrao@chromium.org
BUG=594519
Committed: https://crrev.com/eebcd9484c2ef7eb4ad8199734f8d98a8e3c07d6
Cr-Commit-Position: refs/heads/master@{#381690}

[sdefresne, 2016-03-15 14:05:17]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org, rohitrao@chromium.org

[sdefresne, 2016-03-15 14:05:17]

dpranke: Please take a look.
rohitrao: OWNERS approval.

[Dirk Pranke, 2016-03-16 01:23:22]

lgtm assuming the answer to the question below is "yes".

https://codereview.chromium.org/1797253002/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (left):

https://codereview.chromium.org/1797253002/diff/1/testing/iossim/iossim.mm#ol...
testing/iossim/iossim.mm:74: const int kIPadFamily = 2;
Are these (and the constant on line 113) no longer needed?

[sdefresne, 2016-03-16 10:06:28]

Description was changed from

==========
Add testing/iossim/BUILD.gn to build iossim as host for iOS build.

BUG=594519
==========

to

==========
Add testing/iossim/BUILD.gn to build iossim as host for iOS build.

Remove some dead const variables flagged as such by clang (instead
of deactivating the compiler warning as the change was simple).

BUG=594519
==========

[sdefresne, 2016-03-17 10:41:48]

Description was changed from

==========
Add testing/iossim/BUILD.gn to build iossim as host for iOS build.

Remove some dead const variables flagged as such by clang (instead
of deactivating the compiler warning as the change was simple).

BUG=594519
==========

to

==========
Add testing/iossim/BUILD.gn to build iossim as host for iOS build.

Remove some dead const variables flagged as such by clang (instead
of deactivating the compiler warning as the change was simple).

TBR=rohitrao@chromium.org
BUG=594519
==========

[sdefresne, 2016-03-17 10:51:34]

On 2016/03/16 at 01:23:22, dpranke wrote:
> lgtm assuming the answer to the question below is "yes".
> 
> https://codereview.chromium.org/1797253002/diff/1/testing/iossim/iossim.mm
> File testing/iossim/iossim.mm (left):
> 
>
https://codereview.chromium.org/1797253002/diff/1/testing/iossim/iossim.mm#ol...
> testing/iossim/iossim.mm:74: const int kIPadFamily = 2;
> Are these (and the constant on line 113) no longer needed?

Yes. I forgot to remove them when I did remove obsolete code in
https://codereview.chromium.org/1796093003 (and the error was not flagged with
gyp as an error as we do not enable -Wunused-const-variables when compiling
iossim with gyp). I've removed them in a later patchset of
https://codereview.chromium.org/1796093003, which mean that the change
disappeared from current CL in last patchset.

[sdefresne, 2016-03-17 10:51:37]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-03-17 10:51:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1797253002/#ps20001
(title: "Remove use of //build/config/mac:macosx_version_min_10_9")

[commit-bot: I haz the power, 2016-03-17 10:51:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1797253002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1797253002/20001

[sdefresne, 2016-03-17 10:53:47]

https://codereview.chromium.org/1797253002/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (left):

https://codereview.chromium.org/1797253002/diff/1/testing/iossim/iossim.mm#ol...
testing/iossim/iossim.mm:74: const int kIPadFamily = 2;
On 2016/03/16 at 01:23:22, Dirk Pranke wrote:
> Are these (and the constant on line 113) no longer needed?

Yeah, they cause compilation about unused const variables when building with gn
(not with gyp as they are build with 'chromium_code' set to 0). Since the
changes were minor, I chose to remove dead code instead of adding
-Wno-unused-const-variables to BUILD.gn config.

[commit-bot: I haz the power, 2016-03-17 10:56:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-17 10:58:26]

Description was changed from

==========
Add testing/iossim/BUILD.gn to build iossim as host for iOS build.

Remove some dead const variables flagged as such by clang (instead
of deactivating the compiler warning as the change was simple).

TBR=rohitrao@chromium.org
BUG=594519
==========

to

==========
Add testing/iossim/BUILD.gn to build iossim as host for iOS build.

Remove some dead const variables flagged as such by clang (instead
of deactivating the compiler warning as the change was simple).

TBR=rohitrao@chromium.org
BUG=594519

Committed: https://crrev.com/eebcd9484c2ef7eb4ad8199734f8d98a8e3c07d6
Cr-Commit-Position: refs/heads/master@{#381690}
==========

[commit-bot: I haz the power, 2016-03-17 10:58:27]

Patchset 2 (id:??) landed as
https://crrev.com/eebcd9484c2ef7eb4ad8199734f8d98a8e3c07d6
Cr-Commit-Position: refs/heads/master@{#381690}