Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: build/config/ios/rules.gni

Issue 1800083003: Add iossim as data_deps for iOS application bundles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iossim.gn
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ios/ios_sdk.gni") 5 import("//build/config/ios/ios_sdk.gni")
6 6
7 # TODO(crbug.com/297668): refactor this template to extract common behaviour 7 # TODO(crbug.com/297668): refactor this template to extract common behaviour
8 # between OS X and iOS bundle generation, then create a generic "app" template 8 # between OS X and iOS bundle generation, then create a generic "app" template
9 # that forward to "executable" on all platform except iOS/OS X. 9 # that forward to "executable" on all platform except iOS/OS X.
10 10
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 ]) 138 ])
139 139
140 if (!defined(deps)) { 140 if (!defined(deps)) {
141 deps = [] 141 deps = []
142 } 142 }
143 deps += [ 143 deps += [
144 ":$_bundle_data_executable", 144 ":$_bundle_data_executable",
145 ":$_bundle_data_info_plist", 145 ":$_bundle_data_info_plist",
146 ] 146 ]
147 147
148 if (use_ios_simulator) {
149 if (!defined(data_deps)) {
150 data_deps = []
151 }
152 data_deps += [ "//testing/iossim(//build/toolchain/mac:clang_x64)" ]
Dirk Pranke 2016/03/16 01:22:06 nit: this should probably be "//testing/iossim($ho
sdefresne 2016/03/17 12:11:04 Done.
153 }
154
148 bundle_root_dir = "$root_out_dir/$_app_name.app" 155 bundle_root_dir = "$root_out_dir/$_app_name.app"
149 bundle_resources_dir = bundle_root_dir 156 bundle_resources_dir = bundle_root_dir
150 bundle_executable_dir = bundle_root_dir 157 bundle_executable_dir = bundle_root_dir
151 bundle_plugins_dir = "$bundle_root_dir/Plugins" 158 bundle_plugins_dir = "$bundle_root_dir/Plugins"
152 } 159 }
153 160
154 # TODO(crbug.com/297668): 161 # TODO(crbug.com/297668):
155 # - add support for codesigning, 162 # - add support for codesigning,
156 # - find a way to make "ninja -C out/Default base_unittests.app" work as 163 # - find a way to make "ninja -C out/Default base_unittests.app" work as
157 # an alias to "ninja -C out/Default base_unittests" (for convenience 164 # an alias to "ninja -C out/Default base_unittests" (for convenience
158 # and compatibility with gyp), 165 # and compatibility with gyp),
159 # - implement //testing/iossim(//build/toolchain/mac:clang_x64) and then
160 # add a depency to that target.
161 } 166 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698