cc: Refactor SkipImageCanvas and create it during playback.

cc: Refactor SkipImageCanvas and create it during playback.

This patch moves SkipImageCanvas into a separate file in the same
directory as ImageHijackCanvas and also moves the creation of
SkipImageCanvas to raster source playback (the same place as
ImageHijackCanvas is created).

BUG=594679
R=enne, ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696
Cr-Commit-Position: refs/heads/master@{#381101}

[vmpstr, 2016-03-14 20:55:00]

Description was changed from

==========
cc: Refactor SkipImageCanvas and create it during playback.

This patch moves SkipImageCanvas into a separate file in the same
directory as ImageHijackCanvas and also moves the creation of
SkipImageCanvas to raster source playback (the same place as
ImageHijackCanvas is created).

BUG=594679
R=enne, ericrk
==========

to

==========
cc: Refactor SkipImageCanvas and create it during playback.

This patch moves SkipImageCanvas into a separate file in the same
directory as ImageHijackCanvas and also moves the creation of
SkipImageCanvas to raster source playback (the same place as
ImageHijackCanvas is created).

BUG=594679
R=enne, ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[vmpstr, 2016-03-14 21:01:56]

Please take a look.

[ericrk, 2016-03-14 21:27:53]

lgtm

[ericrk, 2016-03-14 21:40:14]

https://codereview.chromium.org/1799883002/diff/1/cc/playback/display_list_ra...
File cc/playback/display_list_raster_source.cc (right):

https://codereview.chromium.org/1799883002/diff/1/cc/playback/display_list_ra...
cc/playback/display_list_raster_source.cc:103: // discardable images. This way
we would only pay for the hijack canvas if the
nit: comment probably applies to both cases - not just discardable - if a tile
has no images, we don't want to pay the cost of the SkipImagesCanvas?

[vmpstr, 2016-03-14 21:42:58]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-03-14 21:43:14]

On 2016/03/14 21:40:14, ericrk wrote:
>
https://codereview.chromium.org/1799883002/diff/1/cc/playback/display_list_ra...
> File cc/playback/display_list_raster_source.cc (right):
> 
>
https://codereview.chromium.org/1799883002/diff/1/cc/playback/display_list_ra...
> cc/playback/display_list_raster_source.cc:103: // discardable images. This way
> we would only pay for the hijack canvas if the
> nit: comment probably applies to both cases - not just discardable - if a tile
> has no images, we don't want to pay the cost of the SkipImagesCanvas?

Yeah... the comment is like a general one for the block

[commit-bot: I haz the power, 2016-03-14 21:43:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799883002/1

[commit-bot: I haz the power, 2016-03-14 22:51:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-14 22:52:11]

Description was changed from

==========
cc: Refactor SkipImageCanvas and create it during playback.

This patch moves SkipImageCanvas into a separate file in the same
directory as ImageHijackCanvas and also moves the creation of
SkipImageCanvas to raster source playback (the same place as
ImageHijackCanvas is created).

BUG=594679
R=enne, ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Refactor SkipImageCanvas and create it during playback.

This patch moves SkipImageCanvas into a separate file in the same
directory as ImageHijackCanvas and also moves the creation of
SkipImageCanvas to raster source playback (the same place as
ImageHijackCanvas is created).

BUG=594679
R=enne, ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696
Cr-Commit-Position: refs/heads/master@{#381101}
==========

[commit-bot: I haz the power, 2016-03-14 22:52:12]

Patchset 1 (id:??) landed as
https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696
Cr-Commit-Position: refs/heads/master@{#381101}