Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3789)

Unified Diff: cc/output/software_renderer.cc

Issue 1799883002: cc: Refactor SkipImageCanvas and create it during playback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/software_renderer.cc
diff --git a/cc/output/software_renderer.cc b/cc/output/software_renderer.cc
index a2a7c49744ed7fd32203c3a1e58fa9f1dbd6752b..12165b1d57a9fda140e259a1c4649fb697916d77 100644
--- a/cc/output/software_renderer.cc
+++ b/cc/output/software_renderer.cc
@@ -366,18 +366,24 @@ void SoftwareRenderer::DrawPictureQuad(const DrawingFrame* frame,
TRACE_EVENT0("cc", "SoftwareRenderer::DrawPictureQuad");
+ const bool include_images = true;
if (needs_transparency || disable_image_filtering) {
// TODO(aelias): This isn't correct in all cases. We should detect these
// cases and fall back to a persistent bitmap backing
// (http://crbug.com/280374).
+ // TODO(vmpstr): Fold this canvas into playback and have raster source
+ // accept a set of settings on playback that will determine which canvas to
+ // apply. (http://crbug.com/594679)
skia::OpacityFilterCanvas filtered_canvas(current_canvas_,
quad->shared_quad_state->opacity,
disable_image_filtering);
quad->raster_source->PlaybackToSharedCanvas(
- &filtered_canvas, quad->content_rect, quad->contents_scale);
+ &filtered_canvas, quad->content_rect, quad->contents_scale,
+ include_images);
} else {
quad->raster_source->PlaybackToSharedCanvas(
- current_canvas_, quad->content_rect, quad->contents_scale);
+ current_canvas_, quad->content_rect, quad->contents_scale,
+ include_images);
}
}

Powered by Google App Engine
This is Rietveld 408576698