cc: Refactor SkipImageCanvas and create it during playback.

cc/raster/tile_task_worker_pool.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/raster/tile_task_worker_pool.h"
 
 #include <stddef.h>
 
 #include "base/trace_event/trace_event.h"
 #include "cc/playback/display_list_raster_source.h"
 #include "cc/raster/texture_compressor.h"
 #include "skia/ext/refptr.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "third_party/skia/include/core/SkSurface.h"
-#include "third_party/skia/include/utils/SkPaintFilterCanvas.h"
 
 namespace cc {
 
 TileTaskWorkerPool::TileTaskWorkerPool() {}
 
 TileTaskWorkerPool::~TileTaskWorkerPool() {}
 
 // static
 void TileTaskWorkerPool::ScheduleTasksOnOriginThread(TileTaskClient* client,
                                                      TaskGraph* graph) {
@@ skipping 25 matching lines @@
     case LUMINANCE_8:
     case RGB_565:
     case RED_8:
     case LUMINANCE_F16:
       return false;
   }
   NOTREACHED();
   return false;
 }
 
-class SkipImageCanvas : public SkPaintFilterCanvas {
- public:
-  explicit SkipImageCanvas(SkCanvas* canvas) : SkPaintFilterCanvas(canvas) {}
-
-  bool onFilter(SkTCopyOnFirstWrite<SkPaint>* paint, Type type) const override {
-    if (type == kBitmap_Type)
-      return false;
-
-    SkShader* shader = (*paint) ? (*paint)->getShader() : nullptr;
-    return !shader || !shader->isABitmap();
-  }
-
-  void onDrawPicture(const SkPicture* picture,
-                     const SkMatrix* matrix,
-                     const SkPaint* paint) override {
-    SkTCopyOnFirstWrite<SkPaint> filteredPaint(paint);
-
-    // To filter nested draws, we must unfurl pictures at this stage.
-    if (onFilter(&filteredPaint, kPicture_Type))
-      SkCanvas::onDrawPicture(picture, matrix, filteredPaint);
-  }
-};
-
-class AutoSkipImageCanvas {
- public:
-  AutoSkipImageCanvas(SkCanvas* canvas, bool include_images) : canvas_(canvas) {
-    if (!include_images) {
-      skip_image_canvas_ = skia::AdoptRef(new SkipImageCanvas(canvas));
-      canvas_ = skip_image_canvas_.get();
-    }
-  }
-
-  operator SkCanvas*() { return canvas_; }
-
- private:
-  skia::RefPtr<SkCanvas> skip_image_canvas_;
-  SkCanvas* canvas_;
-};
-
 }  // anonymous namespace
 
 // static
 void TileTaskWorkerPool::PlaybackToMemory(
     void* memory,
     ResourceFormat format,
     const gfx::Size& size,
     size_t stride,
     const DisplayListRasterSource* raster_source,
     const gfx::Rect& canvas_bitmap_rect,
@@ skipping 17 matching lines @@
 
   if (!stride)
     stride = info.minRowBytes();
   DCHECK_GT(stride, 0u);
 
   switch (format) {
     case RGBA_8888:
     case BGRA_8888: {
       skia::RefPtr<SkSurface> surface = skia::AdoptRef(
           SkSurface::NewRasterDirect(info, memory, stride, &surface_props));
-      AutoSkipImageCanvas canvas(surface->getCanvas(), include_images);
-      raster_source->PlaybackToCanvas(canvas, canvas_bitmap_rect,
-                                      canvas_playback_rect, scale);
+      raster_source->PlaybackToCanvas(surface->getCanvas(), canvas_bitmap_rect,
+                                      canvas_playback_rect, scale,
+                                      include_images);
       return;
     }
     case RGBA_4444:
     case ETC1: {
       skia::RefPtr<SkSurface> surface =
           skia::AdoptRef(SkSurface::NewRaster(info, &surface_props));
-      AutoSkipImageCanvas canvas(surface->getCanvas(), include_images);
       // TODO(reveman): Improve partial raster support by reducing the size of
       // playback rect passed to PlaybackToCanvas. crbug.com/519070
-      raster_source->PlaybackToCanvas(canvas, canvas_bitmap_rect,
-                                      canvas_bitmap_rect, scale);
+      raster_source->PlaybackToCanvas(surface->getCanvas(), canvas_bitmap_rect,
+                                      canvas_bitmap_rect, scale,
+                                      include_images);
 
       if (format == ETC1) {
         TRACE_EVENT0("cc",
                      "TileTaskWorkerPool::PlaybackToMemory::CompressETC1");
         DCHECK_EQ(size.width() % 4, 0);
         DCHECK_EQ(size.height() % 4, 0);
         scoped_ptr<TextureCompressor> texture_compressor =
             TextureCompressor::Create(TextureCompressor::kFormatETC1);
         texture_compressor->Compress(reinterpret_cast<const uint8_t*>(
                                          surface->peekPixels(nullptr, nullptr)),
@@ skipping 18 matching lines @@
     case RED_8:
     case LUMINANCE_F16:
       NOTREACHED();
       return;
   }
 
   NOTREACHED();
 }
 
 }  // namespace cc