Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: cc/output/software_renderer.cc

Issue 1799883002: cc: Refactor SkipImageCanvas and create it during playback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/software_renderer.h" 5 #include "cc/output/software_renderer.h"
6 6
7 #include "base/trace_event/trace_event.h" 7 #include "base/trace_event/trace_event.h"
8 #include "cc/base/math_util.h" 8 #include "cc/base/math_util.h"
9 #include "cc/output/compositor_frame.h" 9 #include "cc/output/compositor_frame.h"
10 #include "cc/output/compositor_frame_ack.h" 10 #include "cc/output/compositor_frame_ack.h"
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 SkMatrix::kFill_ScaleToFit); 359 SkMatrix::kFill_ScaleToFit);
360 current_canvas_->concat(content_matrix); 360 current_canvas_->concat(content_matrix);
361 361
362 const bool needs_transparency = 362 const bool needs_transparency =
363 SkScalarRoundToInt(quad->shared_quad_state->opacity * 255) < 255; 363 SkScalarRoundToInt(quad->shared_quad_state->opacity * 255) < 255;
364 const bool disable_image_filtering = 364 const bool disable_image_filtering =
365 frame->disable_picture_quad_image_filtering || quad->nearest_neighbor; 365 frame->disable_picture_quad_image_filtering || quad->nearest_neighbor;
366 366
367 TRACE_EVENT0("cc", "SoftwareRenderer::DrawPictureQuad"); 367 TRACE_EVENT0("cc", "SoftwareRenderer::DrawPictureQuad");
368 368
369 const bool include_images = true;
369 if (needs_transparency || disable_image_filtering) { 370 if (needs_transparency || disable_image_filtering) {
370 // TODO(aelias): This isn't correct in all cases. We should detect these 371 // TODO(aelias): This isn't correct in all cases. We should detect these
371 // cases and fall back to a persistent bitmap backing 372 // cases and fall back to a persistent bitmap backing
372 // (http://crbug.com/280374). 373 // (http://crbug.com/280374).
374 // TODO(vmpstr): Fold this canvas into playback and have raster source
375 // accept a set of settings on playback that will determine which canvas to
376 // apply. (http://crbug.com/594679)
373 skia::OpacityFilterCanvas filtered_canvas(current_canvas_, 377 skia::OpacityFilterCanvas filtered_canvas(current_canvas_,
374 quad->shared_quad_state->opacity, 378 quad->shared_quad_state->opacity,
375 disable_image_filtering); 379 disable_image_filtering);
376 quad->raster_source->PlaybackToSharedCanvas( 380 quad->raster_source->PlaybackToSharedCanvas(
377 &filtered_canvas, quad->content_rect, quad->contents_scale); 381 &filtered_canvas, quad->content_rect, quad->contents_scale,
382 include_images);
378 } else { 383 } else {
379 quad->raster_source->PlaybackToSharedCanvas( 384 quad->raster_source->PlaybackToSharedCanvas(
380 current_canvas_, quad->content_rect, quad->contents_scale); 385 current_canvas_, quad->content_rect, quad->contents_scale,
386 include_images);
381 } 387 }
382 } 388 }
383 389
384 void SoftwareRenderer::DrawSolidColorQuad(const DrawingFrame* frame, 390 void SoftwareRenderer::DrawSolidColorQuad(const DrawingFrame* frame,
385 const SolidColorDrawQuad* quad) { 391 const SolidColorDrawQuad* quad) {
386 gfx::RectF visible_quad_vertex_rect = MathUtil::ScaleRectProportional( 392 gfx::RectF visible_quad_vertex_rect = MathUtil::ScaleRectProportional(
387 QuadVertexRect(), gfx::RectF(quad->rect), gfx::RectF(quad->visible_rect)); 393 QuadVertexRect(), gfx::RectF(quad->rect), gfx::RectF(quad->visible_rect));
388 current_paint_.setColor(quad->color); 394 current_paint_.setColor(quad->color);
389 current_paint_.setAlpha(quad->shared_quad_state->opacity * 395 current_paint_.setAlpha(quad->shared_quad_state->opacity *
390 SkColorGetA(quad->color)); 396 SkColorGetA(quad->color));
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
713 ApplyImageFilter(filter.get(), quad, &backdrop_bitmap); 719 ApplyImageFilter(filter.get(), quad, &backdrop_bitmap);
714 720
715 if (!filter_backdrop_image) 721 if (!filter_backdrop_image)
716 return nullptr; 722 return nullptr;
717 723
718 return skia::AdoptRef(filter_backdrop_image->newShader( 724 return skia::AdoptRef(filter_backdrop_image->newShader(
719 content_tile_mode, content_tile_mode, &filter_backdrop_transform)); 725 content_tile_mode, content_tile_mode, &filter_backdrop_transform));
720 } 726 }
721 727
722 } // namespace cc 728 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698